scripts/slave/recipes/android/android_builder.py - Issue 23431038: [chromium_android recipes] Cleanup envsetup step and cleanup step names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/android/android_builder.py

Issue 23431038: [chromium_android recipes] Cleanup envsetup step and cleanup step names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Address comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/chromium_config.py ('k') | scripts/slave/recipes/android/android_builder.expected/clang_builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/android/android_builder.py

diff --git a/scripts/slave/recipes/android/android_builder.py b/scripts/slave/recipes/android/android_builder.py

index fbd0400b1ecf4ceeee740f76c6ec2ddada8ad676..61e16c30e20bdafe1c734afb505c20a7e2243745 100644

--- a/scripts/slave/recipes/android/android_builder.py

+++ b/scripts/slave/recipes/android/android_builder.py

@@ -31,11 +31,11 @@ def GenTests(api):

'x86_builder', 'klp_builder', 'try_builder']

def _common_step_mocks():

return {

- 'Get AppManifestVars': {

+ 'get app_manifest_vars': {

'json': {

'output': {

'version_code': 10,

- 'version_name': 'some builder 1234',

+ 'version_name': 'some_builder_1234',

'build_id': 3333,

'date_string': 6001

}

@@ -45,6 +45,8 @@ def GenTests(api):

'json': {

'output': {

'PATH': './',

+ 'GYP_DEFINES': 'my_new_gyp_def=aaa',

+ 'GYP_SOMETHING': 'gyp_something_value'

}