Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: scripts/slave/recipes/android/android_builder.py

Issue 23431038: [chromium_android recipes] Cleanup envsetup step and cleanup step names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'chromium_android', 6 'chromium_android',
7 'properties', 7 'properties',
8 ] 8 ]
9 9
10 def GenSteps(api): 10 def GenSteps(api):
(...skipping 13 matching lines...) Expand all
24 if droid.c.run_lint: 24 if droid.c.run_lint:
25 yield droid.lint() 25 yield droid.lint()
26 if droid.c.run_checkdeps: 26 if droid.c.run_checkdeps:
27 yield droid.checkdeps() 27 yield droid.checkdeps()
28 28
29 def GenTests(api): 29 def GenTests(api):
30 bot_ids = ['main_builder', 'component_builder', 'clang_builder', 30 bot_ids = ['main_builder', 'component_builder', 'clang_builder',
31 'x86_builder', 'klp_builder', 'try_builder'] 31 'x86_builder', 'klp_builder', 'try_builder']
32 def _common_step_mocks(): 32 def _common_step_mocks():
33 return { 33 return {
34 'Get AppManifestVars': { 34 'get app_manifest_vars': {
35 'json': { 35 'json': {
36 'output': { 36 'output': {
37 'version_code': 10, 37 'version_code': 10,
38 'version_name': 'some builder 1234', 38 'version_name': 'some_builder_1234',
39 'build_id': 3333, 39 'build_id': 3333,
40 'date_string': 6001 40 'date_string': 6001
41 } 41 }
42 } 42 }
43 }, 43 },
44 'envsetup': { 44 'envsetup': {
45 'json': { 45 'json': {
46 'output': { 46 'output': {
47 'PATH': './', 47 'PATH': './',
48 'GYP_DEFINES': 'my_new_gyp_def=aaa',
49 'GYP_SOMETHING': 'gyp_something_value'
48 } 50 }
49 } 51 }
50 } 52 }
51 } 53 }
52 54
53 for bot_id in bot_ids: 55 for bot_id in bot_ids:
54 props = { 56 props = {
55 'repo_name': 'src/repo', 57 'repo_name': 'src/repo',
56 'repo_url': 'svn://svn.chromium.org/chrome/trunk/src', 58 'repo_url': 'svn://svn.chromium.org/chrome/trunk/src',
57 'revision': '4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00', 59 'revision': '4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00',
58 'android_bot_id': bot_id, 60 'android_bot_id': bot_id,
59 'buildername': 'builder_name', 61 'buildername': 'builder_name',
60 'internal': True 62 'internal': True
61 } 63 }
62 if bot_id == 'try_builder': 64 if bot_id == 'try_builder':
63 props['revision'] = '' 65 props['revision'] = ''
64 yield bot_id, { 66 yield bot_id, {
65 'properties': props, 67 'properties': props,
66 'step_mocks': _common_step_mocks() 68 'step_mocks': _common_step_mocks()
67 } 69 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698