Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: scripts/slave/recipes/android/android_builder.expected/component_builder.json

Issue 23431038: [chromium_android recipes] Cleanup envsetup step and cleanup step names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/android/android_builder.expected/component_builder.json
diff --git a/scripts/slave/recipes/android/android_builder.expected/component_builder.json b/scripts/slave/recipes/android/android_builder.expected/component_builder.json
index 01986d142ea53178bf244e946877af86a4006ae2..8184238b350b5aa7b87747faf44aae7c6629ea31 100644
--- a/scripts/slave/recipes/android/android_builder.expected/component_builder.json
+++ b/scripts/slave/recipes/android/android_builder.expected/component_builder.json
@@ -47,13 +47,13 @@
"--output-json",
"/path/to/tmp/json"
],
- "name": "Get AppManifestVars",
+ "name": "get app_manifest_vars",
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"build_id\": 3333, @@@",
"@@@STEP_LOG_LINE@json.output@ \"date_string\": 6001, @@@",
"@@@STEP_LOG_LINE@json.output@ \"version_code\": 10, @@@",
- "@@@STEP_LOG_LINE@json.output@ \"version_name\": \"some builder 1234\"@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"version_name\": \"some_builder_1234\"@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
]
@@ -66,11 +66,13 @@
"[SLAVE_BUILD_ROOT]/src/build/android/envsetup.sh"
],
"env": {
- "EXTRA_LANDMINES_SCRIPT": "[SLAVE_BUILD_ROOT]/src/repo/build/get_internal_landmines.py"
+ "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:"
},
"name": "envsetup",
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"GYP_DEFINES\": \"my_new_gyp_def=aaa\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"GYP_SOMETHING\": \"gyp_something_value\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"PATH\": \"./\"@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
@@ -107,7 +109,7 @@
"src-internal",
"src/repo"
],
- "name": "Tree Truth Steps"
+ "name": "tree truth steps"
},
{
"cmd": [
@@ -117,7 +119,12 @@
"runhooks"
],
"env": {
- "PATH": "./[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
+ "EXTRA_LANDMINES_SCRIPT": "[SLAVE_BUILD_ROOT]/src/repo/build/get_internal_landmines.py",
+ "GYP_CROSSCOMPILE": 1,
+ "GYP_DEFINES": "OS=android app_manifest_version_code=10 app_manifest_version_name=some_builder_1234 chrome_build_id=3333 component=shared_library fastbuild=1 gcc_version=46 host_os=linux order_text_section=[SLAVE_BUILD_ROOT]/src/orderfiles/orderfile.out target_arch=arm",
+ "GYP_GENERATORS": "ninja",
+ "GYP_GENERATOR_FLAGS": "default_target=All",
+ "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
},
"name": "gclient runhooks"
},
@@ -140,7 +147,7 @@
"All"
],
"env": {
- "PATH": "./[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
+ "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
},
"name": "compile"
}

Powered by Google App Engine
This is Rietveld 408576698