Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: scripts/slave/recipes/android/android_builder.expected/component_builder.json

Issue 23431038: [chromium_android recipes] Cleanup envsetup step and cleanup step names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 [ 1 [
2 { 2 {
3 "cmd": [ 3 "cmd": [
4 "python", 4 "python",
5 "-u", 5 "-u",
6 "[DEPOT_TOOLS_ROOT]/gclient.py", 6 "[DEPOT_TOOLS_ROOT]/gclient.py",
7 "config", 7 "config",
8 "--spec", 8 "--spec",
9 "cache_dir = None\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True , 'name': 'src/repo', 'url': 'svn://svn.chromium.org/chrome/trunk/src'}]\ntarget _os = ['android']" 9 "cache_dir = None\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True , 'name': 'src/repo', 'url': 'svn://svn.chromium.org/chrome/trunk/src'}]\ntarget _os = ['android']"
10 ], 10 ],
(...skipping 29 matching lines...) Expand all
40 { 40 {
41 "cmd": [ 41 "cmd": [
42 "[SLAVE_BUILD_ROOT]/src/repo/build/dump_app_manifest_vars.py", 42 "[SLAVE_BUILD_ROOT]/src/repo/build/dump_app_manifest_vars.py",
43 "-b", 43 "-b",
44 "builder_name", 44 "builder_name",
45 "-v", 45 "-v",
46 "[SLAVE_BUILD_ROOT]/src/chrome/VERSION", 46 "[SLAVE_BUILD_ROOT]/src/chrome/VERSION",
47 "--output-json", 47 "--output-json",
48 "/path/to/tmp/json" 48 "/path/to/tmp/json"
49 ], 49 ],
50 "name": "Get AppManifestVars", 50 "name": "get app_manifest_vars",
51 "~followup_annotations": [ 51 "~followup_annotations": [
52 "@@@STEP_LOG_LINE@json.output@{@@@", 52 "@@@STEP_LOG_LINE@json.output@{@@@",
53 "@@@STEP_LOG_LINE@json.output@ \"build_id\": 3333, @@@", 53 "@@@STEP_LOG_LINE@json.output@ \"build_id\": 3333, @@@",
54 "@@@STEP_LOG_LINE@json.output@ \"date_string\": 6001, @@@", 54 "@@@STEP_LOG_LINE@json.output@ \"date_string\": 6001, @@@",
55 "@@@STEP_LOG_LINE@json.output@ \"version_code\": 10, @@@", 55 "@@@STEP_LOG_LINE@json.output@ \"version_code\": 10, @@@",
56 "@@@STEP_LOG_LINE@json.output@ \"version_name\": \"some builder 1234\"@@@ ", 56 "@@@STEP_LOG_LINE@json.output@ \"version_name\": \"some_builder_1234\"@@@ ",
57 "@@@STEP_LOG_LINE@json.output@}@@@", 57 "@@@STEP_LOG_LINE@json.output@}@@@",
58 "@@@STEP_LOG_END@json.output@@@" 58 "@@@STEP_LOG_END@json.output@@@"
59 ] 59 ]
60 }, 60 },
61 { 61 {
62 "cmd": [ 62 "cmd": [
63 "[SLAVE_BUILD_ROOT]/src/build/env_dump.py", 63 "[SLAVE_BUILD_ROOT]/src/build/env_dump.py",
64 "--output-json", 64 "--output-json",
65 "/path/to/tmp/json", 65 "/path/to/tmp/json",
66 "[SLAVE_BUILD_ROOT]/src/build/android/envsetup.sh" 66 "[SLAVE_BUILD_ROOT]/src/build/android/envsetup.sh"
67 ], 67 ],
68 "env": { 68 "env": {
69 "EXTRA_LANDMINES_SCRIPT": "[SLAVE_BUILD_ROOT]/src/repo/build/get_internal_ landmines.py" 69 "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:"
70 }, 70 },
71 "name": "envsetup", 71 "name": "envsetup",
72 "~followup_annotations": [ 72 "~followup_annotations": [
73 "@@@STEP_LOG_LINE@json.output@{@@@", 73 "@@@STEP_LOG_LINE@json.output@{@@@",
74 "@@@STEP_LOG_LINE@json.output@ \"GYP_DEFINES\": \"my_new_gyp_def=aaa\", @ @@",
75 "@@@STEP_LOG_LINE@json.output@ \"GYP_SOMETHING\": \"gyp_something_value\" , @@@",
74 "@@@STEP_LOG_LINE@json.output@ \"PATH\": \"./\"@@@", 76 "@@@STEP_LOG_LINE@json.output@ \"PATH\": \"./\"@@@",
75 "@@@STEP_LOG_LINE@json.output@}@@@", 77 "@@@STEP_LOG_LINE@json.output@}@@@",
76 "@@@STEP_LOG_END@json.output@@@" 78 "@@@STEP_LOG_END@json.output@@@"
77 ] 79 ]
78 }, 80 },
79 { 81 {
80 "cmd": [ 82 "cmd": [
81 "python", 83 "python",
82 "-u", 84 "-u",
83 "\nimport shutil, sys, os\nshutil.rmtree(sys.argv[1], True)\nshutil.rmtree (sys.argv[2], True)\nfor base, _dirs, files in os.walk(sys.argv[3]):\n for f in files:\n if f.endswith('.pyc'):\n os.remove(os.path.join(base, f))\n", 85 "\nimport shutil, sys, os\nshutil.rmtree(sys.argv[1], True)\nshutil.rmtree (sys.argv[2], True)\nfor base, _dirs, files in os.walk(sys.argv[3]):\n for f in files:\n if f.endswith('.pyc'):\n os.remove(os.path.join(base, f))\n",
(...skipping 16 matching lines...) Expand all
100 }, 102 },
101 { 103 {
102 "allow_subannottations": true, 104 "allow_subannottations": true,
103 "cmd": [ 105 "cmd": [
104 "[SLAVE_BUILD_ROOT]/src/build/tree_truth.sh", 106 "[SLAVE_BUILD_ROOT]/src/build/tree_truth.sh",
105 "[SLAVE_BUILD_ROOT]/src", 107 "[SLAVE_BUILD_ROOT]/src",
106 "src", 108 "src",
107 "src-internal", 109 "src-internal",
108 "src/repo" 110 "src/repo"
109 ], 111 ],
110 "name": "Tree Truth Steps" 112 "name": "tree truth steps"
111 }, 113 },
112 { 114 {
113 "cmd": [ 115 "cmd": [
114 "python", 116 "python",
115 "-u", 117 "-u",
116 "[DEPOT_TOOLS_ROOT]/gclient.py", 118 "[DEPOT_TOOLS_ROOT]/gclient.py",
117 "runhooks" 119 "runhooks"
118 ], 120 ],
119 "env": { 121 "env": {
120 "PATH": "./[BUILD_INTERNAL_ROOT]/scripts/slave/android:./" 122 "EXTRA_LANDMINES_SCRIPT": "[SLAVE_BUILD_ROOT]/src/repo/build/get_internal_ landmines.py",
123 "GYP_CROSSCOMPILE": 1,
124 "GYP_DEFINES": "OS=android app_manifest_version_code=10 app_manifest_versi on_name=some_builder_1234 chrome_build_id=3333 component=shared_library fastbuil d=1 gcc_version=46 host_os=linux order_text_section=[SLAVE_BUILD_ROOT]/src/order files/orderfile.out target_arch=arm",
125 "GYP_GENERATORS": "ninja",
126 "GYP_GENERATOR_FLAGS": "default_target=All",
127 "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
121 }, 128 },
122 "name": "gclient runhooks" 129 "name": "gclient runhooks"
123 }, 130 },
124 { 131 {
125 "cmd": [ 132 "cmd": [
126 "python", 133 "python",
127 "-u", 134 "-u",
128 "[BUILD_ROOT]/scripts/slave/compile.py", 135 "[BUILD_ROOT]/scripts/slave/compile.py",
129 "--target", 136 "--target",
130 "Debug", 137 "Debug",
131 "--build-dir", 138 "--build-dir",
132 "[SLAVE_BUILD_ROOT]/src/out", 139 "[SLAVE_BUILD_ROOT]/src/out",
133 "--src-dir", 140 "--src-dir",
134 "[SLAVE_BUILD_ROOT]/src", 141 "[SLAVE_BUILD_ROOT]/src",
135 "--build-tool", 142 "--build-tool",
136 "ninja", 143 "ninja",
137 "--compiler", 144 "--compiler",
138 "goma", 145 "goma",
139 "--", 146 "--",
140 "All" 147 "All"
141 ], 148 ],
142 "env": { 149 "env": {
143 "PATH": "./[BUILD_INTERNAL_ROOT]/scripts/slave/android:./" 150 "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
144 }, 151 },
145 "name": "compile" 152 "name": "compile"
146 } 153 }
147 ] 154 ]
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698