scripts/slave/recipe_modules/chromium/config.py - Issue 23431038: [chromium_android recipes] Cleanup envsetup step and cleanup step names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 23431038: [chromium_android recipes] Cleanup envsetup step and cleanup step names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Address comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-android.arm.32.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium/config.py

diff --git a/scripts/slave/recipe_modules/chromium/config.py b/scripts/slave/recipe_modules/chromium/config.py

index 1b3d6fc344130966fb73c2f21d831824d4dfa2d9..a93b0a2e7ffa0e570c0e4601df706c6430af822d 100644

--- a/scripts/slave/recipe_modules/chromium/config.py

+++ b/scripts/slave/recipe_modules/chromium/config.py

@@ -32,7 +32,8 @@ def BaseConfig(HOST_PLATFORM, HOST_ARCH, HOST_BITS,

compiler = Single(basestring, required=False),

gyp_env = ConfigGroup(

- GYP_DEFINES = Dict(equal_fn, ' '.join, (basestring,int)),

+ GYP_CROSSCOMPILE = Single(int, required=False),

+ GYP_DEFINES = Dict(equal_fn, ' '.join, (basestring,int,list)),

GYP_GENERATORS = Set(basestring, ','.join),

GYP_GENERATOR_FLAGS = Dict(equal_fn, ' '.join, (basestring,int)),

GYP_MSVS_VERSION = Single(basestring, required=False),

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-android.arm.32.json » ('j') | no next file with comments »