Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 23431038: [chromium_android recipes] Cleanup envsetup step and cleanup step names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-android.arm.32.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from slave.recipe_configs_util import config_item_context, ConfigGroup 5 from slave.recipe_configs_util import config_item_context, ConfigGroup
6 from slave.recipe_configs_util import Dict, Single, Static, Set, BadConf 6 from slave.recipe_configs_util import Dict, Single, Static, Set, BadConf
7 7
8 # Because of the way that we use decorators, pylint can't figure out the proper 8 # Because of the way that we use decorators, pylint can't figure out the proper
9 # type signature of functions annotated with the @config_ctx decorator. 9 # type signature of functions annotated with the @config_ctx decorator.
10 # pylint: disable=E1123 10 # pylint: disable=E1123
(...skipping 14 matching lines...) Expand all
25 TARGET_PLATFORM, TARGET_ARCH, TARGET_BITS, 25 TARGET_PLATFORM, TARGET_ARCH, TARGET_BITS,
26 BUILD_CONFIG, **_kwargs): 26 BUILD_CONFIG, **_kwargs):
27 equal_fn = lambda tup: ('%s=%s' % tup) 27 equal_fn = lambda tup: ('%s=%s' % tup)
28 return ConfigGroup( 28 return ConfigGroup(
29 compile_py = ConfigGroup( 29 compile_py = ConfigGroup(
30 default_targets = Set(basestring), 30 default_targets = Set(basestring),
31 build_tool = Single(basestring), 31 build_tool = Single(basestring),
32 compiler = Single(basestring, required=False), 32 compiler = Single(basestring, required=False),
33 ), 33 ),
34 gyp_env = ConfigGroup( 34 gyp_env = ConfigGroup(
35 GYP_DEFINES = Dict(equal_fn, ' '.join, (basestring,int)), 35 GYP_CROSSCOMPILE = Single(int, required=False),
36 GYP_DEFINES = Dict(equal_fn, ' '.join, (basestring,int,list)),
36 GYP_GENERATORS = Set(basestring, ','.join), 37 GYP_GENERATORS = Set(basestring, ','.join),
37 GYP_GENERATOR_FLAGS = Dict(equal_fn, ' '.join, (basestring,int)), 38 GYP_GENERATOR_FLAGS = Dict(equal_fn, ' '.join, (basestring,int)),
38 GYP_MSVS_VERSION = Single(basestring, required=False), 39 GYP_MSVS_VERSION = Single(basestring, required=False),
39 ), 40 ),
40 build_dir = Single(basestring), 41 build_dir = Single(basestring),
41 42
42 # Some platforms do not have a 1:1 correlation of BUILD_CONFIG to what is 43 # Some platforms do not have a 1:1 correlation of BUILD_CONFIG to what is
43 # passed as --target on the command line. 44 # passed as --target on the command line.
44 build_config_fs = Single(basestring), 45 build_config_fs = Single(basestring),
45 46
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 @config_ctx(includes=['ninja', 'default_compiler', 'goma']) 210 @config_ctx(includes=['ninja', 'default_compiler', 'goma'])
210 def chromium(c): 211 def chromium(c):
211 c.compile_py.default_targets = ['All', 'chromium_builder_tests'] 212 c.compile_py.default_targets = ['All', 'chromium_builder_tests']
212 213
213 @config_ctx(includes=['chromium']) 214 @config_ctx(includes=['chromium'])
214 def blink(c): 215 def blink(c):
215 c.compile_py.default_targets = ['all_webkit'] 216 c.compile_py.default_targets = ['all_webkit']
216 if c.TARGET_PLATFORM == 'win': 217 if c.TARGET_PLATFORM == 'win':
217 c.gyp_env.GYP_DEFINES['use_ash'] = 0 218 c.gyp_env.GYP_DEFINES['use_ash'] = 0
218 c.gyp_env.GYP_DEFINES['use_aura'] = 0 219 c.gyp_env.GYP_DEFINES['use_aura'] = 0
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-android.arm.32.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698