Implement Screen::GetAllDisplays for windows.

Implement Screen::GetAllDisplays for windows.

BUG=122863
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221576

[Haojian Wu, 2013-08-25 07:44:45]

Please review it. Thanks.

[Haojian Wu, 2013-08-25 07:49:57]

https://codereview.chromium.org/23415002/diff/1/ui/gfx/screen_win.cc
File ui/gfx/screen_win.cc (right):

https://codereview.chromium.org/23415002/diff/1/ui/gfx/screen_win.cc#newcode24
ui/gfx/screen_win.cc:24: // TODO(oshima): Implement ID and Observer.
oshima@, Do you have any idea about the display |id| implementation?
I think we will need for DisplayInfoProvider.

[oshima, 2013-08-26 18:33:11]

https://codereview.chromium.org/23415002/diff/1/ui/gfx/screen_win.cc
File ui/gfx/screen_win.cc (right):

https://codereview.chromium.org/23415002/diff/1/ui/gfx/screen_win.cc#newcode24
ui/gfx/screen_win.cc:24: // TODO(oshima): Implement ID and Observer.
On 2013/08/25 07:49:58, Haojian Wu wrote:
> oshima@, Do you have any idea about the display |id| implementation?
> I think we will need for DisplayInfoProvider.

Can you take deviceID and generate hash using base::Hash function into
int64? If the data isn't available, then just use index (which is consistent
with chromeos)

[Haojian Wu, 2013-08-30 13:52:15]

https://codereview.chromium.org/23415002/diff/1/ui/gfx/screen_win.cc
File ui/gfx/screen_win.cc (right):

https://codereview.chromium.org/23415002/diff/1/ui/gfx/screen_win.cc#newcode24
ui/gfx/screen_win.cc:24: // TODO(oshima): Implement ID and Observer.
On 2013/08/26 18:33:12, oshima wrote:
> On 2013/08/25 07:49:58, Haojian Wu wrote:
> > oshima@, Do you have any idea about the display |id| implementation?
> > I think we will need for DisplayInfoProvider.
> 
> Can you take deviceID and generate hash using base::Hash function into
> int64? If the data isn't available, then just use index (which is consistent
> with chromeos)

I have separated a new CL to finish this. see
https://codereview.chromium.org/23707010/

[oshima, 2013-08-30 18:15:41]

ok lgtm

[commit-bot: I haz the power, 2013-09-05 01:39:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/23415002/9001

[commit-bot: I haz the power, 2013-09-05 02:46:21]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 07:10:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/23415002/9001

[commit-bot: I haz the power, 2013-09-05 07:36:44]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-06 04:47:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/23415002/9001

[commit-bot: I haz the power, 2013-09-06 05:19:08]

Change committed as 221576