Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 23404002: Add support for ES3 MSAA. (Closed)

Created:
7 years, 4 months ago by bsalomon
Modified:
7 years, 3 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add support for ES3 MSAA. Committed: http://code.google.com/p/skia/source/detail?r=11124

Patch Set 1 #

Patch Set 2 : #

Total comments: 12

Patch Set 3 : rebase and comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -17 lines) Patch
M include/gpu/gl/GrGLConfig.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLConfig_chrome.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 chunks +20 lines, -14 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 2 1 chunk +22 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 2 chunks +38 lines, -0 lines 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 2 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bsalomon
I added an ugly macro to stage this WRT rolling Chrome. Chrome creates their own ...
7 years, 4 months ago (2013-08-23 17:11:48 UTC) #1
robertphillips
lgtm + questions https://codereview.chromium.org/23404002/diff/9001/include/gpu/gl/GrGLConfig.h File include/gpu/gl/GrGLConfig.h (right): https://codereview.chromium.org/23404002/diff/9001/include/gpu/gl/GrGLConfig.h#newcode165 include/gpu/gl/GrGLConfig.h:165: // We now have a separate ...
7 years, 4 months ago (2013-08-23 17:25:34 UTC) #2
bsalomon
https://codereview.chromium.org/23404002/diff/9001/include/gpu/gl/GrGLConfig.h File include/gpu/gl/GrGLConfig.h (right): https://codereview.chromium.org/23404002/diff/9001/include/gpu/gl/GrGLConfig.h#newcode165 include/gpu/gl/GrGLConfig.h:165: // We now have a separate GrGLInterface function pointer ...
7 years, 4 months ago (2013-08-23 17:28:49 UTC) #3
jvanverth1
Just one comment: https://codereview.chromium.org/23404002/diff/9001/include/gpu/gl/GrGLInterface.h File include/gpu/gl/GrGLInterface.h (right): https://codereview.chromium.org/23404002/diff/9001/include/gpu/gl/GrGLInterface.h#newcode246 include/gpu/gl/GrGLInterface.h:246: #endif Maybe a comment here stating ...
7 years, 3 months ago (2013-08-27 17:39:06 UTC) #4
bsalomon
https://codereview.chromium.org/23404002/diff/9001/include/gpu/gl/GrGLInterface.h File include/gpu/gl/GrGLInterface.h (right): https://codereview.chromium.org/23404002/diff/9001/include/gpu/gl/GrGLInterface.h#newcode246 include/gpu/gl/GrGLInterface.h:246: #endif On 2013/08/27 17:39:06, JimVV wrote: > Maybe a ...
7 years, 3 months ago (2013-09-05 22:00:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23404002/20001
7 years, 3 months ago (2013-09-05 22:00:32 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 23:44:14 UTC) #7
Message was sent while issue was closed.
Change committed as 11124

Powered by Google App Engine
This is Rietveld 408576698