Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 23389005: Fix editing/spelling/spellcheck-editable-on-focus.html's flakiness (Closed)

Created:
7 years, 4 months ago by pstanek
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix editing/spelling/spellcheck-editable-on-focus.html's flakiness Due to asynchronous spell checker being on for the test misspelling marks may appear after some time. The test checks misspellings in different elements this is why it has to wait until markers appear in *all* of them before checking the pass conditions. However the test was not waiting if markers appeared in at least one element. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M LayoutTests/editing/spelling/spellcheck-editable-on-focus.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pstanek
7 years, 4 months ago (2013-08-23 17:22:21 UTC) #1
tony
LGTM, but please fix the change description. It should say how the test was incorrect ...
7 years, 4 months ago (2013-08-23 17:25:09 UTC) #2
pstanek
On 2013/08/23 17:25:09, tony wrote: > LGTM, but please fix the change description. It should ...
7 years, 4 months ago (2013-08-23 17:33:22 UTC) #3
tony
On 2013/08/23 17:33:22, pstanek wrote: > On 2013/08/23 17:25:09, tony wrote: > > LGTM, but ...
7 years, 4 months ago (2013-08-23 17:37:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pstanek@opera.com/23389005/1
7 years, 4 months ago (2013-08-23 17:37:37 UTC) #5
pstanek
On 2013/08/23 17:37:06, tony wrote: > On 2013/08/23 17:33:22, pstanek wrote: > > On 2013/08/23 ...
7 years, 4 months ago (2013-08-23 17:38:40 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 19:00:59 UTC) #7
Message was sent while issue was closed.
Change committed as 156650

Powered by Google App Engine
This is Rietveld 408576698