LayoutTests/editing/spelling/spellcheck-editable-on-focus.html - Issue 23389005: Fix editing/spelling/spellcheck-editable-on-focus.html's flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/spelling/spellcheck-editable-on-focus.html

Issue 23389005: Fix editing/spelling/spellcheck-editable-on-focus.html's flakiness (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/editing/spelling/spellcheck-editable-on-focus.html

diff --git a/LayoutTests/editing/spelling/spellcheck-editable-on-focus.html b/LayoutTests/editing/spelling/spellcheck-editable-on-focus.html

index 0aa189b2856f93394cf1cfab1560c627b909f907..aef52b22bc186a6215588f2f9a40c29e7d7a38da 100644

--- a/LayoutTests/editing/spelling/spellcheck-editable-on-focus.html

+++ b/LayoutTests/editing/spelling/spellcheck-editable-on-focus.html

@@ -36,9 +36,9 @@ function test()

function waitForMarkersToAppear(nretry)

{

if (nretry > 0

- && !internals.markerCountForNode(findFirstTextNode(testEditable), "spelling")

- && !internals.markerCountForNode(findFirstTextNode(testTextArea), "spelling")

- && !internals.markerCountForNode(findFirstTextNode(testTextField), "spelling")) {

+ && (!internals.markerCountForNode(findFirstTextNode(testEditable), "spelling")

+ || !internals.markerCountForNode(findFirstTextNode(testTextArea), "spelling")

+ || !internals.markerCountForNode(findFirstTextNode(testTextField), "spelling"))) {

window.setTimeout(function() { waitForMarkersToAppear(nretry - 1); }, 5);

} else {

shouldBe('internals.markerCountForNode(findFirstTextNode(testTextArea), "spelling")', '3');

« no previous file with comments | « no previous file | no next file » | no next file with comments »