WebCrypto: properly normalize optional numeric parameters.

WebCrypto: properly normalize optional numeric parameters.

This addresses a FIXME, and also improves an exception message.

BUG=245025
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156675

[do-not-use, 2013-08-22 22:28:13]

LGTM for bindings/ with nit.

https://codereview.chromium.org/23361019/diff/1/Source/bindings/v8/Dictionary.h
File Source/bindings/v8/Dictionary.h (right):

https://codereview.chromium.org/23361019/diff/1/Source/bindings/v8/Dictionary...
Source/bindings/v8/Dictionary.h:106: bool hasValue(const String&) const;
maybe we can call this contains() like in WTF::HashMap?
I find hasValue() to be confusing since we really check it contains a given key.

[eroman, 2013-08-22 22:42:13]

https://codereview.chromium.org/23361019/diff/1/Source/bindings/v8/Dictionary.h
File Source/bindings/v8/Dictionary.h (right):

https://codereview.chromium.org/23361019/diff/1/Source/bindings/v8/Dictionary...
Source/bindings/v8/Dictionary.h:106: bool hasValue(const String&) const;
On 2013/08/22 22:28:13, Christophe Dumez wrote:
> maybe we can call this contains() like in WTF::HashMap?
> I find hasValue() to be confusing since we really check it contains a given
key.

Done.

I agree that is a better name.

[abarth-chromium, 2013-08-23 19:25:50]

https://codereview.chromium.org/23361019/diff/2001/Source/bindings/v8/Diction...
File Source/bindings/v8/Dictionary.h (right):

https://codereview.chromium.org/23361019/diff/2001/Source/bindings/v8/Diction...
Source/bindings/v8/Dictionary.h:106: bool contains(const String&) const;
This is not a good idea.  The problem is that JavaScript object can behave
differently each time they are interrogated.  If you check that the Dictionary
contains a given key, that doesn't mean it will still have it when you actually
try to get the key.  The act of getting the key can mutate the dictionary.

You can't split the contains and get steps.  You have to do both at the same
time.  not lgtm.

[eroman, 2013-08-23 22:04:03]

https://codereview.chromium.org/23361019/diff/2001/Source/bindings/v8/Diction...
File Source/bindings/v8/Dictionary.h (right):

https://codereview.chromium.org/23361019/diff/2001/Source/bindings/v8/Diction...
Source/bindings/v8/Dictionary.h:106: bool contains(const String&) const;
On 2013/08/23 19:25:50, abarth wrote:
> This is not a good idea.  The problem is that JavaScript object can behave
> differently each time they are interrogated.  If you check that the Dictionary
> contains a given key, that doesn't mean it will still have it when you
actually
> try to get the key.  The act of getting the key can mutate the dictionary.
> 
> You can't split the contains and get steps.  You have to do both at the same
> time.  not lgtm.

Thanks. I have tried to address this, please take another look.

[abarth-chromium, 2013-08-24 18:19:28]

lgtm

Thanks!

[commit-bot: I haz the power, 2013-08-24 18:19:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/23361019/13001

[commit-bot: I haz the power, 2013-08-24 20:40:18]

Change committed as 156675