WebCrypto: properly normalize optional numeric parameters.

Source/modules/crypto/NormalizeAlgorithm.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 217 matching lines @@
 
 bool getUint8Array(const Dictionary& raw, const char* propertyName, RefPtr<Uint8Array>& array, const ExceptionContext& context, ExceptionState& es)
 {
     if (!raw.get(propertyName, array) || !array) {
         es.throwTypeError(context.toString(propertyName, "Missing or not a Uint8Array"));
         return false;
     }
     return true;
 }
 
-bool getInteger(const Dictionary& raw, const char* propertyName, double& value, double minValue, double maxValue, const ExceptionContext& context, ExceptionState& es)
+// Gets an integer according to WebIDL's [EnforceRange].
+bool getOptionalInteger(const Dictionary& raw, const char* propertyName, bool& hasProperty, double& value, double minValue, double maxValue, const ExceptionContext& context, ExceptionState& es)
 {
     double number;
-    if (!raw.get(propertyName, number)) {
-        es.throwTypeError(context.toString(propertyName, "Missing or not a number"));
-        return false;
-    }
+    bool ok = raw.get(propertyName, number, hasProperty);
 
-    // Convert to an integer according to WebIDL's [EnforceRange].
-    if (std::isinf(number) || std::isnan(number)) {
-        es.throwTypeError(context.toString(propertyName, "Outside of numeric range"));
+    if (!hasProperty)
+        return true;
+
+    if (!ok || std::isnan(number)) {
+        es.throwTypeError(context.toString(propertyName, "Is not a number"));
         return false;
     }
 
     number = trunc(number);
 
-    if (number < minValue || number > maxValue) {
+    if (std::isinf(number) || number < minValue || number > maxValue) {
         es.throwTypeError(context.toString(propertyName, "Outside of numeric range"));
         return false;
     }
 
     value = number;
     return true;
 }
 
-bool getOptionalInteger(const Dictionary& raw, const char* propertyName, bool& hasValue, double& value, double minValue, double maxValue, const ExceptionContext& context, ExceptionState& es)
+bool getInteger(const Dictionary& raw, const char* propertyName, double& value, double minValue, double maxValue, const ExceptionContext& context, ExceptionState& es)
 {
-    double number;
-    if (!raw.get(propertyName, number)) {
-        // FIXME: If the property exists but is NOT a number, should fail.
-        hasValue = false;
-        return true;
+    bool hasProperty;
+    if (!getOptionalInteger(raw, propertyName, hasProperty, value, minValue, maxValue, context, es))
+        return false;
+
+    if (!hasProperty) {
+        es.throwTypeError(context.toString(propertyName, "Missing required property"));
+        return false;
     }
 
-    hasValue = true;
-    return getInteger(raw, propertyName, value, minValue, maxValue, context, es);
+    return true;
 }
 
 bool getUint32(const Dictionary& raw, const char* propertyName, uint32_t& value, const ExceptionContext& context, ExceptionState& es)
 {
     double number;
     if (!getInteger(raw, propertyName, number, 0, 0xFFFFFFFF, context, es))
         return false;
     value = number;
     return true;
 }
@@ skipping 66 matching lines @@
     return true;
 }
 
 bool parseHmacKeyParams(const Dictionary& raw, OwnPtr<WebKit::WebCryptoAlgorithmParams>& params, const ExceptionContext& context, ExceptionState& es)
 {
     WebKit::WebCryptoAlgorithm hash;
     if (!parseHash(raw, hash, context, es))
         return false;
 
     bool hasLength;
-    uint32_t length;
+    uint32_t length = 0;
     if (!getOptionalUint32(raw, "length", hasLength, length, context, es))
         return false;
 
     params = adoptPtr(new WebKit::WebCryptoHmacKeyParams(hash, hasLength, length));
     return true;
 }
 
 bool parseRsaSsaParams(const Dictionary& raw, OwnPtr<WebKit::WebCryptoAlgorithmParams>& params, const ExceptionContext& context, ExceptionState& es)
 {
     WebKit::WebCryptoAlgorithm hash;
@@ skipping 95 matching lines @@
 }
 
 } // namespace
 
 bool normalizeAlgorithm(const Dictionary& raw, AlgorithmOperation op, WebKit::WebCryptoAlgorithm& algorithm, ExceptionState& es)
 {
     return normalizeAlgorithm(raw, op, algorithm, ExceptionContext(), es);
 }
 
 } // namespace WebCore