Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issue 23361017: [Android] Fixes getting the revision from build_properties (Closed)

Created:
7 years, 4 months ago by gkanwar1
Modified:
7 years, 4 months ago
Reviewers:
Isaac (away)
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, frankf
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Fixes getting the revision from build_properties NOTRY=True BUG=255644 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
gkanwar1
ptal, thanks
7 years, 4 months ago (2013-08-22 21:22:32 UTC) #1
gkanwar1
On 2013/08/22 21:22:32, gkanwar1 wrote: > ptal, thanks This does appear to be an issue. ...
7 years, 4 months ago (2013-08-23 03:52:32 UTC) #2
Isaac (away)
lgtm
7 years, 4 months ago (2013-08-23 03:56:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/23361017/1
7 years, 4 months ago (2013-08-23 05:08:21 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 05:27:16 UTC) #5
Message was sent while issue was closed.
Change committed as 219223

Powered by Google App Engine
This is Rietveld 408576698