build/android/buildbot/bb_device_steps.py - Issue 23361017: [Android] Fixes getting the revision from build_properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 23361017: [Android] Fixes getting the revision from build_properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/buildbot/bb_device_steps.py

diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py

index 92a3e1bb05b5c952a3ca7a865f0e8ca6eaebbfe9..2cb431ed88b8de620212c936f1609340d6b92f4a 100755

--- a/build/android/buildbot/bb_device_steps.py

+++ b/build/android/buildbot/bb_device_steps.py

@@ -314,7 +314,9 @@ def UploadCoverageData(options, path, coverage_type):

Returns:

None.

"""

- revision = options.build_properties.get('got_revision', 'testing')

+ revision = options.build_properties.get('got_revision')

+ if not revision:

+ revision = options.build_properties.get('revision', 'testing')

bot_id = options.build_properties.get('buildername', 'testing')

randhash = hashlib.sha1(str(random.random())).hexdigest()

gs_path = '%s/%s/%s/%s/%s' % (options.coverage_bucket, coverage_type,

« no previous file with comments | « no previous file | no next file » | no next file with comments »