Create new target to hold gpu test code, enable direct testing of GrEffects in GM.

Create new target to hold gpu test code, enable direct testing of GrEffects in GM.

Committed: http://code.google.com/p/skia/source/detail?r=10866

[bsalomon, 2013-08-20 13:59:40]

Somehow when I moved things around in git branches I really confused rietveld.
git cl upload kept failing. So I created a new issue for this and deleted the
old one.

[robertphillips, 2013-08-20 16:47:34]

lgtm + some comment suggestions & questions.

https://codereview.chromium.org/23352003/diff/3001/gm/beziereffects.cpp
File gm/beziereffects.cpp (right):

https://codereview.chromium.org/23352003/diff/3001/gm/beziereffects.cpp#newco...
gm/beziereffects.cpp:20: 
// Position & KLM coefficient. These are the vertex attributes for Bezier
curves. The last value of the Vec4f is ignored.

https://codereview.chromium.org/23352003/diff/3001/gm/beziereffects.cpp#newco...
gm/beziereffects.cpp:29: 
Should the namespace also enclose kAttribs & eval_line?

https://codereview.chromium.org/23352003/diff/3001/gm/beziereffects.cpp#newco...
gm/beziereffects.cpp:31: 
// This GM ...

https://codereview.chromium.org/23352003/diff/3001/gm/beziereffects.cpp#newco...
gm/beziereffects.cpp:121: bounds.set(pts, 4);
Doesn't set do all of the following 8 lines?

https://codereview.chromium.org/23352003/diff/3001/gm/beziereffects.cpp#newco...
gm/beziereffects.cpp:136: 
Move "Vertex verts[4];" down here?

https://codereview.chromium.org/23352003/diff/3001/src/gpu/GrTest.cpp
File src/gpu/GrTest.cpp (right):

https://codereview.chromium.org/23352003/diff/3001/src/gpu/GrTest.cpp#newcode34
src/gpu/GrTest.cpp:34: 
This is an odd place for this.

[bsalomon, 2013-08-21 14:15:28]

Rob's comments

[bsalomon, 2013-08-21 14:16:03]

https://codereview.chromium.org/23352003/diff/3001/gm/beziereffects.cpp
File gm/beziereffects.cpp (right):

https://codereview.chromium.org/23352003/diff/3001/gm/beziereffects.cpp#newco...
gm/beziereffects.cpp:20: 
On 2013/08/20 16:47:34, robertphillips wrote:
> // Position & KLM coefficient. These are the vertex attributes for Bezier
> curves. The last value of the Vec4f is ignored.

Done.

https://codereview.chromium.org/23352003/diff/3001/gm/beziereffects.cpp#newco...
gm/beziereffects.cpp:29: 
On 2013/08/20 16:47:34, robertphillips wrote:
> Should the namespace also enclose kAttribs & eval_line?

I don't think so.

https://codereview.chromium.org/23352003/diff/3001/gm/beziereffects.cpp#newco...
gm/beziereffects.cpp:31: 
On 2013/08/20 16:47:34, robertphillips wrote:
> // This GM ...

Done.

https://codereview.chromium.org/23352003/diff/3001/gm/beziereffects.cpp#newco...
gm/beziereffects.cpp:121: bounds.set(pts, 4);
On 2013/08/20 16:47:34, robertphillips wrote:
> Doesn't set do all of the following 8 lines?

oops.. yes... this creeped in when Greg and I were debugging something.

https://codereview.chromium.org/23352003/diff/3001/gm/beziereffects.cpp#newco...
gm/beziereffects.cpp:136: 
On 2013/08/20 16:47:34, robertphillips wrote:
> Move "Vertex verts[4];" down here?

Done.

https://codereview.chromium.org/23352003/diff/3001/src/gpu/GrTest.cpp
File src/gpu/GrTest.cpp (right):

https://codereview.chromium.org/23352003/diff/3001/src/gpu/GrTest.cpp#newcode34
src/gpu/GrTest.cpp:34: 
On 2013/08/20 16:47:34, robertphillips wrote:
> This is an odd place for this.

The idea was for this file to be a grab bag of small test-only function impls.
If it gets too big we can split it out:

GrContext_test.cpp
...

[commit-bot: I haz the power, 2013-08-21 19:04:07]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23352003/9001

[commit-bot: I haz the power, 2013-08-21 19:28:00]

Change committed as 10866