Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 23330003: Separate render-specific code in InputType::attach. (Closed)

Created:
7 years, 4 months ago by tkent
Modified:
7 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Separate renderer-specific code in InputType::attach. Introduce new function InputType::countUsage, and move UseCounter code to it. InputType::attach implementations have only renderer-specific code. This is a preparation to support author Shadow DOM for INPUT element. BUG=274205 TEST=none; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M Source/core/html/ColorInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ColorInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DateInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DateInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DateTimeLocalInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DateTimeLocalInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/EmailInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/EmailInputType.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/InputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/InputType.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/MonthInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MonthInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/NumberInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/NumberInputType.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/RangeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RangeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/SearchInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/SearchInputType.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/TelephoneInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TelephoneInputType.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/TextInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TextInputType.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/TimeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/URLInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/URLInputType.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/WeekInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/WeekInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
7 years, 4 months ago (2013-08-20 07:24:28 UTC) #1
keishi
lgtm
7 years, 4 months ago (2013-08-20 08:19:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/23330003/1
7 years, 4 months ago (2013-08-20 08:46:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/23330003/1
7 years, 4 months ago (2013-08-20 08:51:04 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-20 09:11:24 UTC) #5
Message was sent while issue was closed.
Change committed as 156380

Powered by Google App Engine
This is Rietveld 408576698