Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 23321002: Convert 'document.domain' exceptions to 'es.throwSecurityError()'. (Closed)

Created:
7 years, 4 months ago by Mike West
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Convert 'document.domain' exceptions to 'es.throwSecurityError()'. BUG=275282 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M LayoutTests/fast/dom/Document/invalid-domain-change-throws-exception-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Document/script-tests/invalid-domain-change-throws-exception.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/setDomainRelaxationForbiddenForURLScheme-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
Moar. -mike
7 years, 4 months ago (2013-08-19 10:26:07 UTC) #1
Mike West
On 2013/08/19 10:26:07, Mike West wrote: > Moar. > > -mike Since you reviewed the ...
7 years, 4 months ago (2013-08-19 14:32:26 UTC) #2
jochen (gone - plz use gerrit)
indeed lgtm
7 years, 4 months ago (2013-08-19 14:33:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/23321002/1
7 years, 4 months ago (2013-08-19 14:34:43 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-19 15:50:36 UTC) #5
Message was sent while issue was closed.
Change committed as 156312

Powered by Google App Engine
This is Rietveld 408576698