Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23316003: [content shell] move browser process stuff into browser/ subdir (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 4 months ago
CC:
chromium-reviews, asanka, sadrul, yusukes+watch_chromium.org, tzik+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, sievers+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, aandrey+blink_chromium.org, miu+watch_chromium.org, jbauman+watch_chromium.org, vsevik, ben+watch_chromium.org, aboxhall+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, Michael van Ouwerkerk, piman+watch_chromium.org, ctguil+watch_chromium.org, jochen+watch_chromium.org, zork+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, yurys, davidbarr+watch_chromium.org, benjhayden+dwatch_chromium.org, dtseng+watch_chromium.org, danakj+watch_chromium.org, James Su, pfeldman
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -8444 lines) Patch
M PRESUBMIT.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell/content_client/shell_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/accessibility_win_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/cross_platform_accessibility_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/bookmarklet_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/database_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_orientation/device_orientation_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/download/drag_download_file_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_crash_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_functional_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_memory_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_pixel_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/webgl_conformance_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_internals_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_data_remover_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/security_exploit_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/session_history_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_recognition_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webkit_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/test/worker_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/content_shell.gypi View 5 chunks +67 lines, -67 lines 0 comments Download
M content/renderer/dom_serializer_browsertest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/resource_fetcher_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/savable_resources_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/shell_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/shell_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/shell/browser/minimal_shell.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/minimal_shell.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/browser/notify_done_forwarder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/notify_done_forwarder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/shell/browser/shell.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell.cc View 2 chunks +7 lines, -7 lines 0 comments Download
A + content/shell/browser/shell_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/browser/shell_application_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_application_mac.mm View 1 chunk +4 lines, -4 lines 0 comments Download
A + content/shell/browser/shell_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/shell/browser/shell_browser_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_browser_context.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_browser_main.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_browser_main.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/shell/browser/shell_browser_main_parts.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_browser_main_parts.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + content/shell/browser/shell_browser_main_parts_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/shell/browser/shell_content_browser_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_content_browser_client.cc View 2 chunks +11 lines, -11 lines 0 comments Download
A + content/shell/browser/shell_devtools_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_devtools_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/shell/browser/shell_devtools_frontend.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_devtools_frontend.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A + content/shell/browser/shell_download_manager_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_download_manager_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/shell/browser/shell_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_javascript_dialog.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_javascript_dialog_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_javascript_dialog_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/shell/browser/shell_javascript_dialog_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_javascript_dialog_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_javascript_dialog_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_layout_tests_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_layout_tests_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/browser/shell_login_dialog.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_login_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/browser/shell_login_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/browser/shell_login_dialog_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/browser/shell_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/browser/shell_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_message_filter.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + content/shell/browser/shell_net_log.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_net_log.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/browser/shell_network_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_network_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/browser/shell_plugin_service_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_plugin_service_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/browser/shell_quota_permission_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_quota_permission_context.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/browser/shell_resource_dispatcher_host_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_resource_dispatcher_host_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/shell/browser/shell_url_request_context_getter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_url_request_context_getter.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + content/shell/browser/shell_web_contents_view_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_web_contents_view_delegate_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/shell/browser/shell_web_contents_view_delegate_creator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_web_contents_view_delegate_gtk.cc View 2 chunks +7 lines, -7 lines 0 comments Download
A + content/shell/browser/shell_web_contents_view_delegate_mac.mm View 2 chunks +7 lines, -7 lines 0 comments Download
A + content/shell/browser/shell_web_contents_view_delegate_win.cc View 2 chunks +7 lines, -7 lines 0 comments Download
A + content/shell/browser/shell_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/shell/browser/webkit_test_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/webkit_test_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/shell/geolocation/shell_access_token_store.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/shell/minimal_shell.h View 1 chunk +0 lines, -67 lines 0 comments Download
D content/shell/minimal_shell.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D content/shell/notify_done_forwarder.h View 1 chunk +0 lines, -34 lines 0 comments Download
D content/shell/notify_done_forwarder.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D content/shell/shell.h View 1 chunk +0 lines, -286 lines 0 comments Download
D content/shell/shell.cc View 1 chunk +0 lines, -367 lines 0 comments Download
D content/shell/shell_android.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D content/shell/shell_application_mac.h View 1 chunk +0 lines, -27 lines 0 comments Download
D content/shell/shell_application_mac.mm View 1 chunk +0 lines, -39 lines 0 comments Download
D content/shell/shell_aura.cc View 1 chunk +0 lines, -374 lines 0 comments Download
D content/shell/shell_browser_context.h View 1 chunk +0 lines, -83 lines 0 comments Download
D content/shell/shell_browser_context.cc View 1 chunk +0 lines, -215 lines 0 comments Download
D content/shell/shell_browser_main.h View 1 chunk +0 lines, -19 lines 0 comments Download
D content/shell/shell_browser_main.cc View 1 chunk +0 lines, -220 lines 0 comments Download
D content/shell/shell_browser_main_parts.h View 1 chunk +0 lines, -70 lines 0 comments Download
D content/shell/shell_browser_main_parts.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D content/shell/shell_browser_main_parts_mac.mm View 1 chunk +0 lines, -25 lines 0 comments Download
D content/shell/shell_content_browser_client.h View 1 chunk +0 lines, -103 lines 0 comments Download
D content/shell/shell_content_browser_client.cc View 1 chunk +0 lines, -275 lines 0 comments Download
D content/shell/shell_devtools_delegate.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/shell/shell_devtools_delegate.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D content/shell/shell_devtools_frontend.h View 1 chunk +0 lines, -73 lines 0 comments Download
D content/shell/shell_devtools_frontend.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D content/shell/shell_download_manager_delegate.h View 1 chunk +0 lines, -65 lines 0 comments Download
D content/shell/shell_download_manager_delegate.cc View 1 chunk +0 lines, -211 lines 0 comments Download
D content/shell/shell_gtk.cc View 1 chunk +0 lines, -339 lines 0 comments Download
D content/shell/shell_javascript_dialog.h View 1 chunk +0 lines, -64 lines 0 comments Download
D content/shell/shell_javascript_dialog_gtk.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D content/shell/shell_javascript_dialog_mac.mm View 1 chunk +0 lines, -138 lines 0 comments Download
D content/shell/shell_javascript_dialog_manager.h View 1 chunk +0 lines, -67 lines 0 comments Download
D content/shell/shell_javascript_dialog_manager.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D content/shell/shell_javascript_dialog_win.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D content/shell/shell_layout_tests_android.h View 1 chunk +0 lines, -25 lines 0 comments Download
D content/shell/shell_layout_tests_android.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D content/shell/shell_login_dialog.h View 1 chunk +0 lines, -97 lines 0 comments Download
D content/shell/shell_login_dialog.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D content/shell/shell_login_dialog_gtk.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D content/shell/shell_login_dialog_mac.mm View 1 chunk +0 lines, -122 lines 0 comments Download
D content/shell/shell_mac.mm View 1 chunk +0 lines, -334 lines 0 comments Download
D content/shell/shell_message_filter.h View 1 chunk +0 lines, -66 lines 0 comments Download
D content/shell/shell_message_filter.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D content/shell/shell_net_log.h View 1 chunk +0 lines, -28 lines 0 comments Download
D content/shell/shell_net_log.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D content/shell/shell_network_delegate.h View 1 chunk +0 lines, -71 lines 0 comments Download
D content/shell/shell_network_delegate.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D content/shell/shell_plugin_service_filter.h View 1 chunk +0 lines, -37 lines 0 comments Download
D content/shell/shell_plugin_service_filter.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D content/shell/shell_quota_permission_context.h View 1 chunk +0 lines, -34 lines 0 comments Download
D content/shell/shell_quota_permission_context.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D content/shell/shell_resource_dispatcher_host_delegate.h View 1 chunk +0 lines, -40 lines 0 comments Download
D content/shell/shell_resource_dispatcher_host_delegate.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D content/shell/shell_url_request_context_getter.h View 1 chunk +0 lines, -69 lines 0 comments Download
D content/shell/shell_url_request_context_getter.cc View 1 1 chunk +0 lines, -231 lines 0 comments Download
D content/shell/shell_web_contents_view_delegate.h View 1 chunk +0 lines, -83 lines 0 comments Download
D content/shell/shell_web_contents_view_delegate_android.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D content/shell/shell_web_contents_view_delegate_creator.h View 1 chunk +0 lines, -18 lines 0 comments Download
D content/shell/shell_web_contents_view_delegate_gtk.cc View 1 chunk +0 lines, -241 lines 0 comments Download
D content/shell/shell_web_contents_view_delegate_mac.mm View 1 chunk +0 lines, -277 lines 0 comments Download
D content/shell/shell_web_contents_view_delegate_win.cc View 1 chunk +0 lines, -254 lines 0 comments Download
D content/shell/shell_win.cc View 1 chunk +0 lines, -285 lines 0 comments Download
D content/shell/webkit_test_controller.h View 1 chunk +0 lines, -219 lines 0 comments Download
D content/shell/webkit_test_controller.cc View 1 chunk +0 lines, -632 lines 0 comments Download
M content/test/accessibility_browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/content_browser_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/content_browser_test_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/content_browser_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/content_test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-19 08:12:32 UTC) #1
marja
rubberstamp lgtm
7 years, 4 months ago (2013-08-19 08:19:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/23316003/1
7 years, 4 months ago (2013-08-19 08:21:29 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=21226
7 years, 4 months ago (2013-08-19 08:36:41 UTC) #4
jochen (gone - plz use gerrit)
TBR joi for the presubmit update, and ben for updating includes all over content and ...
7 years, 4 months ago (2013-08-19 13:16:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/23316003/1
7 years, 4 months ago (2013-08-19 13:16:51 UTC) #6
Jói
PRESUBMIT.py LGTM
7 years, 4 months ago (2013-08-19 13:54:31 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=160460
7 years, 4 months ago (2013-08-19 17:28:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/23316003/30001
7 years, 4 months ago (2013-08-20 07:01:47 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-20 11:30:45 UTC) #10
Message was sent while issue was closed. 
Change committed as 218441

Powered by Google App Engine
This is Rietveld 408576698