OLD | NEW |
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
9 """ | 9 """ |
10 | 10 |
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
150 (), | 150 (), |
151 ), | 151 ), |
152 ( | 152 ( |
153 'ScopedAllowIO', | 153 'ScopedAllowIO', |
154 ( | 154 ( |
155 'New code should not use ScopedAllowIO. Post a task to the blocking', | 155 'New code should not use ScopedAllowIO. Post a task to the blocking', |
156 'pool or the FILE thread instead.', | 156 'pool or the FILE thread instead.', |
157 ), | 157 ), |
158 True, | 158 True, |
159 ( | 159 ( |
160 r"^content[\\\/]shell[\\\/]shell_browser_main\.cc$", | 160 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", |
| 161 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", |
161 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", | 162 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", |
162 ), | 163 ), |
163 ), | 164 ), |
164 ( | 165 ( |
165 'SkRefPtr', | 166 'SkRefPtr', |
166 ( | 167 ( |
167 'The use of SkRefPtr is prohibited. ', | 168 'The use of SkRefPtr is prohibited. ', |
168 'Please use skia::RefPtr instead.' | 169 'Please use skia::RefPtr instead.' |
169 ), | 170 ), |
170 True, | 171 True, |
(...skipping 882 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
1053 trybots += ['linux_chromeos_clang:compile', 'linux_chromeos_asan'] | 1054 trybots += ['linux_chromeos_clang:compile', 'linux_chromeos_asan'] |
1054 | 1055 |
1055 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it | 1056 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it |
1056 # unless they're .gyp(i) files as changes to those files can break the gyp | 1057 # unless they're .gyp(i) files as changes to those files can break the gyp |
1057 # step on that bot. | 1058 # step on that bot. |
1058 if (not all(re.search('^chrome', f) for f in files) or | 1059 if (not all(re.search('^chrome', f) for f in files) or |
1059 any(re.search('\.gypi?$', f) for f in files)): | 1060 any(re.search('\.gypi?$', f) for f in files)): |
1060 trybots += ['android_aosp'] | 1061 trybots += ['android_aosp'] |
1061 | 1062 |
1062 return trybots | 1063 return trybots |
OLD | NEW |