Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: PRESUBMIT.py

Issue 23316003: [content shell] move browser process stuff into browser/ subdir (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ash/shell/content_client/shell_browser_main_parts.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 (), 150 (),
151 ), 151 ),
152 ( 152 (
153 'ScopedAllowIO', 153 'ScopedAllowIO',
154 ( 154 (
155 'New code should not use ScopedAllowIO. Post a task to the blocking', 155 'New code should not use ScopedAllowIO. Post a task to the blocking',
156 'pool or the FILE thread instead.', 156 'pool or the FILE thread instead.',
157 ), 157 ),
158 True, 158 True,
159 ( 159 (
160 r"^content[\\\/]shell[\\\/]shell_browser_main\.cc$", 160 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",
161 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",
161 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", 162 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$",
162 ), 163 ),
163 ), 164 ),
164 ( 165 (
165 'SkRefPtr', 166 'SkRefPtr',
166 ( 167 (
167 'The use of SkRefPtr is prohibited. ', 168 'The use of SkRefPtr is prohibited. ',
168 'Please use skia::RefPtr instead.' 169 'Please use skia::RefPtr instead.'
169 ), 170 ),
170 True, 171 True,
(...skipping 882 matching lines...) Expand 10 before | Expand all | Expand 10 after
1053 trybots += ['linux_chromeos_clang:compile', 'linux_chromeos_asan'] 1054 trybots += ['linux_chromeos_clang:compile', 'linux_chromeos_asan']
1054 1055
1055 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1056 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1056 # unless they're .gyp(i) files as changes to those files can break the gyp 1057 # unless they're .gyp(i) files as changes to those files can break the gyp
1057 # step on that bot. 1058 # step on that bot.
1058 if (not all(re.search('^chrome', f) for f in files) or 1059 if (not all(re.search('^chrome', f) for f in files) or
1059 any(re.search('\.gypi?$', f) for f in files)): 1060 any(re.search('\.gypi?$', f) for f in files)):
1060 trybots += ['android_aosp'] 1061 trybots += ['android_aosp']
1061 1062
1062 return trybots 1063 return trybots
OLDNEW
« no previous file with comments | « no previous file | ash/shell/content_client/shell_browser_main_parts.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698