Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23301009: Add libpoppler for PDF rendering, take 2 (Closed)

Created:
7 years, 4 months ago by ducky
Modified:
7 years, 4 months ago
Visibility:
Public.

Description

Add libpoppler for PDF rendering, take 2 Committed: http://code.google.com/p/skia/source/detail?r=10833

Patch Set 1 : Base patchset from 20220002 #

Patch Set 2 : Fix freetype.gyp file - accidentally nuked the override include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14849 lines, -53 lines) Patch
A gyp/fontconfig.gyp View 1 chunk +101 lines, -0 lines 0 comments Download
M gyp/freetype.gyp View 1 2 chunks +29 lines, -53 lines 0 comments Download
A gyp/freetype.gypi View 1 chunk +65 lines, -0 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +11 lines, -0 lines 0 comments Download
A gyp/iconv.gyp View 1 chunk +44 lines, -0 lines 0 comments Download
A gyp/poppler.gyp View 1 chunk +229 lines, -0 lines 0 comments Download
A src/utils/SkPDFRasterizer.h View 1 chunk +15 lines, -0 lines 0 comments Download
A src/utils/SkPDFRasterizer.cpp View 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/fontconfig/LICENSE View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/fontconfig/LICENSE.win View 1 chunk +118 lines, -0 lines 0 comments Download
A third_party/fontconfig/README.chromium View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/fc-case/fccase.h View 1 chunk +330 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/fc-glyphname/fcglyphname.h View 1 chunk +781 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/fc-lang/fclang.h View 1 chunk +4173 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/mac/config.h View 1 chunk +358 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/mac/fcstdint.h View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/mac/src/fcalias.h View 1 chunk +388 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/mac/src/fcaliastail.h View 1 chunk +438 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/mac/src/fcftalias.h View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/mac/src/fcftaliastail.h View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/src/fcobjshash.h View 1 chunk +317 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/windows/config.h View 1 chunk +237 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/windows/dirent.h View 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/windows/dirent.c View 1 chunk +145 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/windows/fcstdint.h View 1 chunk +237 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/windows/src/fcalias.h View 1 chunk +368 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/windows/src/fcaliastail.h View 1 chunk +738 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/windows/src/fcftalias.h View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/windows/src/fcftaliastail.h View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/fontconfig/config/windows/unistd.h View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/iconv/LICENSE View 1 chunk +482 lines, -0 lines 0 comments Download
A third_party/iconv/README.chromium View 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/iconv/config/aliases.h View 1 chunk +1719 lines, -0 lines 0 comments Download
A third_party/iconv/config/canonical.h View 1 chunk +110 lines, -0 lines 0 comments Download
A third_party/iconv/config/canonical_dos.h View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/iconv/config/canonical_local.h View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/iconv/config/flags.h View 1 chunk +157 lines, -0 lines 0 comments Download
A third_party/iconv/config/windows/config.h View 1 chunk +926 lines, -0 lines 0 comments Download
A third_party/iconv/config/windows/iconv.h View 1 chunk +244 lines, -0 lines 0 comments Download
A third_party/iconv/config/windows/localcharset.h View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/poppler/LICENSE View 1 chunk +339 lines, -0 lines 0 comments Download
A third_party/poppler/README.chromium View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/poppler/config/linux/config.h View 1 chunk +259 lines, -0 lines 0 comments Download
A third_party/poppler/config/linux/poppler-config.h View 1 chunk +174 lines, -0 lines 0 comments Download
A third_party/poppler/config/mac/config.h View 1 chunk +259 lines, -0 lines 0 comments Download
A third_party/poppler/config/mac/poppler-config.h View 1 chunk +174 lines, -0 lines 0 comments Download
A third_party/poppler/config/poppler-version.h View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/poppler/config/windows/config.h View 1 chunk +225 lines, -0 lines 0 comments Download
A third_party/poppler/config/windows/poppler-config.h View 1 chunk +173 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ducky
Empty comment so the buildbots list doesn't go off the screen . . . . ...
7 years, 4 months ago (2013-08-20 17:32:30 UTC) #1
ducky
This should fix the NaCl build issues. Turns out the overrides for freetype_static were accidentally ...
7 years, 4 months ago (2013-08-20 17:55:06 UTC) #2
vandebo (ex-Chrome)
LGTM
7 years, 4 months ago (2013-08-20 18:47:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/richardlin@chromium.org/23301009/4001
7 years, 4 months ago (2013-08-20 18:50:43 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-20 18:57:29 UTC) #5
Message was sent while issue was closed. 
Change committed as 10833

Powered by Google App Engine
This is Rietveld 408576698