| OLD | NEW | 
|---|
| (Empty) |  | 
|  | 1 Name: libiconv | 
|  | 2 Short Name: libiconv | 
|  | 3 URL: git://git.savannah.gnu.org/libiconv.git | 
|  | 4 Version: 1.14 | 
|  | 5 License: Libraries under LGPL, program under GPL | 
|  | 6 License File: NOT_SHIPPED | 
|  | 7 Security Critical: No | 
|  | 8 | 
|  | 9 Description: | 
|  | 10 iconv is a library for converting between different character encodings. | 
|  | 11 Used in Skia as a dependency of libpoppler, for PDF rasterization during | 
|  | 12 testing. | 
|  | 13 | 
|  | 14 Local Modifications: | 
|  | 15 No changes to files from the upstream repository. | 
|  | 16 Platform-specific configuration files added to | 
|  | 17 third_party/iconv/config/windows: | 
|  | 18   config.h | 
|  | 19   iconv.h | 
|  | 20   localcharset.h | 
|  | 21 | 
|  | 22 These files were created from the header templates based on instructions in: | 
|  | 23 http://www.codeproject.com/Articles/302012/How-to-Build-libiconv-with-Microsoft-
    Visual-Studio, | 
|  | 24 then kludging it to build. The process used to create them from release | 
|  | 25 sources are: | 
|  | 26 1. Download the libiconv-1.14 tarball from | 
|  | 27    http://www.gnu.org/software/libiconv/#downloading | 
|  | 28 2. Copy and rename these files: | 
|  | 29     (libiconv-1.14)/libcharset/include/localcharset.h.build.in | 
|  | 30       -> third_party/iconv/config/windows/localcharset.h | 
|  | 31     (libiconv-1.14)/include/iconv.h.build.in | 
|  | 32       -> third_party/iconv/config/windows/iconv.h | 
|  | 33     (libiconv-1.14)/config.h.in | 
|  | 34       -> third_party/iconv/config/windows/config.h | 
|  | 35 3. Modify localcharset.h as follows: | 
|  | 36     Replace | 
|  | 37       #if @HAVE_VISIBILITY@ && BUILDING_LIBCHARSET | 
|  | 38       #define LIBCHARSET_DLL_EXPORTED __attribute__((__visibility__("default"))) | 
|  | 39       #else | 
|  | 40       #define LIBCHARSET_DLL_EXPORTED | 
|  | 41       #endif | 
|  | 42     with | 
|  | 43       #define LIBCHARSET_DLL_EXPORTED | 
|  | 44 4. Modify config.h as follows: | 
|  | 45     Delete line 30: | 
|  | 46       #undef EILSEQ | 
|  | 47     Change line 686 to: | 
|  | 48       #define ICONV_CONST const | 
|  | 49 5. Modify iconv.h as follows: | 
|  | 50     Replace | 
|  | 51       #if @HAVE_VISIBILITY@ && BUILDING_LIBICONV | 
|  | 52       #define LIBICONV_DLL_EXPORTED __attribute__((__visibility__("default"))) | 
|  | 53       #else | 
|  | 54       #define LIBICONV_DLL_EXPORTED | 
|  | 55       #endif | 
|  | 56     with | 
|  | 57       #define LIBICONV_DLL_EXPORTED | 
|  | 58     Delete all references to @DLL_VARIABLE@ (find and replace with nothing). | 
|  | 59     Find and replace these: | 
|  | 60       @ICONV_CONST@ -> const | 
|  | 61       @USE_MBSTATE_T@ -> USE_MBSTATE_T | 
|  | 62       @BROKEN_WCHAR_H@ -> BROKEN_WCHAR_H | 
|  | 63       @HAVE_WCHAR_T@ -> HAVE_WCHAR_T | 
|  | 64 Note: if a dynamic library is needed for whatever reason, | 
|  | 65 LIBCHARSET_DLL_EXPORTED and LIBICONV_DLL_EXPORTED needs to be defined as | 
|  | 66 either __declspec(dllexport) or __declspec(dllimport). | 
|  | 67 | 
|  | 68 Autogenerated files (consistent across platforms) added to | 
|  | 69 third_party/iconv/config: | 
|  | 70   aliases.h | 
|  | 71   canonical_dos.h | 
|  | 72   canonical.h | 
|  | 73   canonical_local.h | 
|  | 74   flags.h | 
|  | 75 | 
|  | 76 These files were pulled from a release tarball. | 
|  | 77 | 
| OLD | NEW | 
|---|