Require handshake confirmation until a QUIC connection is created succesfully when using a new netw…

net/quic/test_tools/mock_crypto_client_stream.cc

Index: net/quic/test_tools/mock_crypto_client_stream.cc
diff --git a/net/quic/test_tools/mock_crypto_client_stream.cc b/net/quic/test_tools/mock_crypto_client_stream.cc
index 79c335317144862d20d68bd646a8b7f84d7cb835..bfeb06f06292d450b6e52133dac61be187a183d6 100644
--- a/net/quic/test_tools/mock_crypto_client_stream.cc
+++ b/net/quic/test_tools/mock_crypto_client_stream.cc
@@ -51,6 +51,16 @@ bool MockCryptoClientStream::CryptoConnect() {
   return true;
 }
 
+void MockCryptoClientStream::SendOnCryptoHandshakeEvent(
+    QuicSession::CryptoHandshakeEvent event) {

[ramant (doing other things), 2013/08/19 18:39:05]

overly nit: consider adding a "DCHECK_NE(event, COLD_START);" to avoid wrong
usage of this method (if it makes sense). What do you think?

[Ryan Hamilton, 2013/08/19 18:51:18]

I like the idea, but COLD_START is one of the hanshake modes defined in this
mock class.  |event| is a QuicSession::CryptoHandshakeEvent, which only includes
initially established, re-established, handshake confirmed.  So I think we're ok
here.

+  encryption_established_ = true;
+  if (event == QuicSession::HANDSHAKE_CONFIRMED) {
+    handshake_confirmed_ = true;
+    SetConfigNegotiated();
+  }
+  session()->OnCryptoHandshakeEvent(event);
+}
+
 void MockCryptoClientStream::SetConfigNegotiated() {
   ASSERT_FALSE(session()->config()->negotiated());
   QuicTagVector cgst;