Require handshake confirmation until a QUIC connection is created succesfully when using a new netw…

net/quic/test_tools/mock_crypto_client_stream.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/test_tools/mock_crypto_client_stream.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 MockCryptoClientStream::MockCryptoClientStream(
@@ skipping 33 matching lines @@
 
     case COLD_START: {
       handshake_confirmed_ = false;
       encryption_established_ = false;
       break;
     }
   }
   return true;
 }
 
+void MockCryptoClientStream::SendOnCryptoHandshakeEvent(
+    QuicSession::CryptoHandshakeEvent event) {

[ramant (doing other things), 2013/08/19 18:39:05]

overly nit: consider adding a "DCHECK_NE(event, COLD_START);" to avoid wrong
usage of this method (if it makes sense). What do you think?

[Ryan Hamilton, 2013/08/19 18:51:18]

I like the idea, but COLD_START is one of the hanshake modes defined in this
mock class.  |event| is a QuicSession::CryptoHandshakeEvent, which only includes
initially established, re-established, handshake confirmed.  So I think we're ok
here.

+  encryption_established_ = true;
+  if (event == QuicSession::HANDSHAKE_CONFIRMED) {
+    handshake_confirmed_ = true;
+    SetConfigNegotiated();
+  }
+  session()->OnCryptoHandshakeEvent(event);
+}
+
 void MockCryptoClientStream::SetConfigNegotiated() {
   ASSERT_FALSE(session()->config()->negotiated());
   QuicTagVector cgst;
   cgst.push_back(kINAR);
   cgst.push_back(kQBIC);
   session()->config()->set_congestion_control(cgst, kQBIC);
   session()->config()->set_idle_connection_state_lifetime(
       QuicTime::Delta::FromSeconds(2 * kDefaultTimeoutSecs),
       QuicTime::Delta::FromSeconds(kDefaultTimeoutSecs));
   session()->config()->set_max_streams_per_connection(
       2 * kDefaultMaxStreamsPerConnection, kDefaultMaxStreamsPerConnection);
 
   CryptoHandshakeMessage msg;
   session()->config()->ToHandshakeMessage(&msg);
   string error_details;
   const QuicErrorCode error =
       session()->config()->ProcessClientHello(msg, &error_details);
   ASSERT_EQ(QUIC_NO_ERROR, error);
   ASSERT_TRUE(session()->config()->negotiated());
 }
 
 }  // namespace net