Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23264035: Merge 218339 "Submitting https://codereview.chromium.org/2311600..." (Closed)

Created:
7 years, 4 months ago by whywhat
Modified:
7 years, 4 months ago
Reviewers:
whywhat
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 218339 "Submitting https://codereview.chromium.org/2311600..." > Submitting https://codereview.chromium.org/23116003/ for Cihat Imamoglu. > > Adds PrintingContext implementation stub for Android. > > ORIGINAL_BUG=147070 > TBR=thestig@chromium.org > > Review URL: https://codereview.chromium.org/22999026 BUG=275991 TBR=avayvod@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -34 lines) Patch
M build/common.gypi View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/android/testshell/testshell_stubs.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android_test_stubs.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager_basic.h View 3 chunks +29 lines, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager_basic.cc View 2 chunks +31 lines, -1 line 0 comments Download
M chrome/browser/printing/printing_message_filter.h View 1 chunk +12 lines, -2 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 7 chunks +64 lines, -3 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/print_messages.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_mock_render_thread.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_mock_render_thread.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/renderer/printing/print_web_view_helper_android.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_linux.cc View 3 chunks +8 lines, -6 lines 0 comments Download
A + printing/image_android.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M printing/image_linux.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M printing/metafile.h View 2 chunks +3 lines, -3 lines 0 comments Download
M printing/pdf_metafile_skia.h View 1 chunk +2 lines, -2 lines 0 comments Download
M printing/pdf_metafile_skia.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printed_document.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M printing/printing.gyp View 2 chunks +6 lines, -0 lines 0 comments Download
A + printing/printing_context_android.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M skia/skia_chrome.gypi View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia_library.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
whywhat
7 years, 4 months ago (2013-08-22 11:19:59 UTC) #1
whywhat
7 years, 4 months ago (2013-08-22 11:21:03 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r218994.

Powered by Google App Engine
This is Rietveld 408576698