Fix content browser test failure by enabling WebRuntimeFeatures::enableInputModeAttribute

Fix content browser test failure by enabling WebRuntimeFeatures::enableInputModeAttribute

BUG=276821
R=jochen@chromium.org, kochi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219246

[yoichio, 2013-08-22 03:46:38]

Or we should rewrite the test using/making WebKit::WebWidget mock which depends
on enableTestOnlyFeatures?

[kochi, 2013-08-22 04:00:22]

https://codereview.chromium.org/23264032/diff/1/content/renderer/render_view_...
File content/renderer/render_view_browsertest.cc (right):

https://codereview.chromium.org/23264032/diff/1/content/renderer/render_view_...
content/renderer/render_view_browsertest.cc:779:
WebKit::WebRuntimeFeatures::enableTestOnlyFeatures(true);
Can you enable only InputMode, and not in test function but
in SetUp() method?

I recommend you write a comment like TODO(yoichio): Remove this
once InputMode feature is enabled by default.

[yoichio, 2013-08-22 06:00:46]

https://chromiumcodereview.appspot.com/23264032/diff/1/content/renderer/rende...
File content/renderer/render_view_browsertest.cc (right):

https://chromiumcodereview.appspot.com/23264032/diff/1/content/renderer/rende...
content/renderer/render_view_browsertest.cc:779:
WebKit::WebRuntimeFeatures::enableTestOnlyFeatures(true);
On 2013/08/22 04:00:22, Takayoshi Kochi wrote:
> Can you enable only InputMode, and not in test function but
> in SetUp() method?
> 
> I recommend you write a comment like TODO(yoichio): Remove this
> once InputMode feature is enabled by default.

Done.

[jochen (gone - plz use gerrit), 2013-08-22 06:28:45]

lgtm

https://chromiumcodereview.appspot.com/23264032/diff/16001/content/renderer/r...
File content/renderer/render_view_browsertest.cc (right):

https://chromiumcodereview.appspot.com/23264032/diff/16001/content/renderer/r...
content/renderer/render_view_browsertest.cc:131:
WebKit::WebRuntimeFeatures::enableInputModeAttribute(true);
nit. add using WebKit::WebRuntimeFeatures to the list starting at line 59

[yoichio, 2013-08-22 06:48:36]

https://chromiumcodereview.appspot.com/23264032/diff/16001/content/renderer/r...
File content/renderer/render_view_browsertest.cc (right):

https://chromiumcodereview.appspot.com/23264032/diff/16001/content/renderer/r...
content/renderer/render_view_browsertest.cc:131:
WebKit::WebRuntimeFeatures::enableInputModeAttribute(true);
On 2013/08/22 06:28:45, jochen wrote:
> nit. add using WebKit::WebRuntimeFeatures to the list starting at line 59

Done.

[commit-bot: I haz the power, 2013-08-22 06:49:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoichio@chromium.org/23264032/21001

[kochi, 2013-08-22 06:50:28]

lgtm

[commit-bot: I haz the power, 2013-08-22 07:13:02]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-08-23 01:38:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoichio@chromium.org/23264032/21001

[commit-bot: I haz the power, 2013-08-23 02:21:42]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-08-23 02:50:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoichio@chromium.org/23264032/21001

[commit-bot: I haz the power, 2013-08-23 03:32:41]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-08-23 05:51:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoichio@chromium.org/23264032/21001

[commit-bot: I haz the power, 2013-08-23 06:29:58]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-08-23 06:39:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoichio@chromium.org/23264032/21001

[commit-bot: I haz the power, 2013-08-23 07:21:16]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[yoichio, 2013-08-23 07:36:19]

Committed patchset #3 manually as r219246 (presubmit successful).