Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2325843002: Use an uncacheable page for the Lo-Fi integration test (Closed)

Created:
4 years, 3 months ago by megjablon
Modified:
4 years, 3 months ago
Reviewers:
tbansal1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use an uncacheable page for the Lo-Fi integration test BUG=644983 Committed: https://crrev.com/8a4ae2701f7b46969e5b413deb29f751a37d5455 Cr-Commit-Position: refs/heads/master@{#417448}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Messages

Total messages: 12 (6 generated)
megjablon
PTAL, thanks
4 years, 3 months ago (2016-09-08 23:25:41 UTC) #3
tbansal1
lgtm https://codereview.chromium.org/2325843002/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py File tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py (right): https://codereview.chromium.org/2325843002/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py#newcode11 tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py:11: A test page for the chrome proxy Lo-Fi ...
4 years, 3 months ago (2016-09-08 23:28:38 UTC) #4
megjablon
https://codereview.chromium.org/2325843002/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py File tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py (right): https://codereview.chromium.org/2325843002/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py#newcode11 tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py:11: A test page for the chrome proxy Lo-Fi tests. ...
4 years, 3 months ago (2016-09-08 23:40:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325843002/20001
4 years, 3 months ago (2016-09-08 23:40:27 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 00:26:42 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 00:27:58 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a4ae2701f7b46969e5b413deb29f751a37d5455
Cr-Commit-Position: refs/heads/master@{#417448}

Powered by Google App Engine
This is Rietveld 408576698