Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2445423003:
Don't show the infobar promo for users that disable Data Saver (Closed)
|
Created:
4 years, 1 month ago by megjablon Modified:
4 years, 1 month ago Reviewers:
David Trainor- moved to gerrit CC:
chromium-reviews, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't show the infobar promo for users that disable Data Saver
If the user manually disables Data Saver in the settings menu, don't show
the infobar promo.
BUG=659247
Committed: https://crrev.com/1ffe7912f4809f616d09bfec293f0da98990ba73
Cr-Commit-Position: refs/heads/master@{#427873}
Patch Set 1 #Patch Set 2 : change upstream #
Depends on Patchset: Messages
Total messages: 21 (15 generated)
Description was changed from ========== Don't show the infobar promo for users that disable Data Saver If the user manually disables Data Saver in the settings menu, don't show the infobar promo. Also, remove unused version code for the promo. BUG= ========== to ========== Don't show the infobar promo for users that disable Data Saver If the user manually disables Data Saver in the settings menu, don't show the infobar promo. BUG= ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== Don't show the infobar promo for users that disable Data Saver If the user manually disables Data Saver in the settings menu, don't show the infobar promo. BUG= ========== to ========== Don't show the infobar promo for users that disable Data Saver If the user manually disables Data Saver in the settings menu, don't show the infobar promo. BUG=659247 ==========
megjablon@chromium.org changed reviewers: + yfriedman@chromium.org
PTAL, thanks!
megjablon@chromium.org changed reviewers: - yfriedman@chromium.org
megjablon@chromium.org changed reviewers: + dtrainor@chromium.org
lgtm
The CQ bit was checked by megjablon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #3 (id:60001) has been deleted
The CQ bit was checked by megjablon@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dtrainor@chromium.org Link to the patchset: https://codereview.chromium.org/2445423003/#ps40001 (title: "change master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Don't show the infobar promo for users that disable Data Saver If the user manually disables Data Saver in the settings menu, don't show the infobar promo. BUG=659247 ========== to ========== Don't show the infobar promo for users that disable Data Saver If the user manually disables Data Saver in the settings menu, don't show the infobar promo. BUG=659247 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Don't show the infobar promo for users that disable Data Saver If the user manually disables Data Saver in the settings menu, don't show the infobar promo. BUG=659247 ========== to ========== Don't show the infobar promo for users that disable Data Saver If the user manually disables Data Saver in the settings menu, don't show the infobar promo. BUG=659247 Committed: https://crrev.com/1ffe7912f4809f616d09bfec293f0da98990ba73 Cr-Commit-Position: refs/heads/master@{#427873} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1ffe7912f4809f616d09bfec293f0da98990ba73 Cr-Commit-Position: refs/heads/master@{#427873} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
