Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 23247002: Remove base::Callback from ContextProvider creation. (Closed)

Created:
7 years, 4 months ago by danakj
Modified:
7 years, 4 months ago
Reviewers:
no sievers, piman
CC:
chromium-reviews, jbauman+watch_chromium.org, Ian Vollick, jam, apatrick_chromium, sievers+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org, aelias_OOO_until_Jul13, boliu, jbauman
Visibility:
Public.

Description

Remove base::Callback from ContextProvider creation. Currently a Callback is given to ContextProvider's creation methods that is able to create a WebGraphicsContext3D and return it to the provider. This callback is called synchronously during the create method, and only one time. Instead of requiring this indirection through a Callback, we can instead just pass a WebGraphicsContext3D to the ContextProvider when it is created, directly. R=piman, sievers BUG=258625 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -120 lines) Patch
M content/browser/android/in_process/synchronous_compositor_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/aura/gpu_process_transport_factory.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 3 chunks +7 lines, -16 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.h View 2 chunks +3 lines, -8 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 2 chunks +10 lines, -17 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/compositor/compositor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/compositor/compositor.cc View 2 chunks +13 lines, -20 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.h View 2 chunks +3 lines, -9 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.cc View 3 chunks +14 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
7 years, 4 months ago (2013-08-15 15:41:17 UTC) #1
piman
LGTM, nice!
7 years, 4 months ago (2013-08-15 17:08:47 UTC) #2
no sievers
lgtm
7 years, 4 months ago (2013-08-15 18:17:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/23247002/1
7 years, 4 months ago (2013-08-16 00:50:55 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 04:58:16 UTC) #5
Message was sent while issue was closed.
Change committed as 217934

Powered by Google App Engine
This is Rietveld 408576698