Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23245003: Remove SigninManager::StartSignIn() since /ClientLogin is no longer used. (Closed)

Created:
7 years, 4 months ago by Roger Tawa OOO till Jul 10th
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove SigninManager::StartSignIn() since /ClientLogin is no longer used. BUG=92948 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221919

Patch Set 1 : rebased #

Patch Set 2 : Put type back #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Patch Set 6 : rebased #

Patch Set 7 : Undo changes to GaiaAuthFetcher #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -222 lines) Patch
M chrome/browser/signin/fake_signin_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/signin/fake_signin_manager.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/signin/signin_manager.h View 1 2 chunks +2 lines, -16 lines 0 comments Download
M chrome/browser/signin/signin_manager.cc View 1 2 chunks +0 lines, -39 lines 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 3 chunks +9 lines, -156 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Tim, Please take a look. Thanks.
7 years, 3 months ago (2013-08-30 14:23:12 UTC) #1
tim (not reviewing)
LGTM
7 years, 3 months ago (2013-09-05 05:18:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/23245003/75001
7 years, 3 months ago (2013-09-05 15:47:51 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-05 16:04:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/23245003/75001
7 years, 3 months ago (2013-09-05 18:56:30 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-05 19:20:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/23245003/105001
7 years, 3 months ago (2013-09-07 12:28:18 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 15:47:14 UTC) #8
Message was sent while issue was closed. 
Change committed as 221919

Powered by Google App Engine
This is Rietveld 408576698