Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/browser/signin/signin_manager.h

Issue 23245003: Remove SigninManager::StartSignIn() since /ClientLogin is no longer used. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Undo changes to GaiaAuthFetcher Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/fake_signin_manager.cc ('k') | chrome/browser/signin/signin_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_manager.h
diff --git a/chrome/browser/signin/signin_manager.h b/chrome/browser/signin/signin_manager.h
index 3c54c943f0918d1fbfa441efe19a4283e1754df0..7e26c9de04b1bc6fec95c9320a6128c2732579dd 100644
--- a/chrome/browser/signin/signin_manager.h
+++ b/chrome/browser/signin/signin_manager.h
@@ -75,20 +75,6 @@ class SigninManager : public SigninManagerBase,
static bool IsUsernameAllowedByPolicy(const std::string& username,
const std::string& policy);
- // Attempt to sign in this user with ClientLogin. If successful, set a
- // preference indicating the signed in user and send out a notification,
- // then start fetching tokens for the user.
- // This is overridden for test subclasses that don't want to issue auth
- // requests.
- virtual void StartSignIn(const std::string& username,
- const std::string& password,
- const std::string& login_token,
- const std::string& login_captcha);
-
- // Used when a second factor access code was required to complete a signin
- // attempt.
- void ProvideSecondFactorAccessCode(const std::string& access_code);
-
// Attempt to sign in this user with existing credentials from the cookie jar.
// |session_index| indicates which user account to use if the cookie jar
// contains a multi-login session. Otherwise the end result of this call is
@@ -197,14 +183,14 @@ class SigninManager : public SigninManagerBase,
bool prohibit_signout_;
private:
+ // TODO(guohui): Leaving the sign in type here because a follow up CL by
+ // Hui will add a new type. Hui: please remove this comment in your CL.
enum SigninType {
SIGNIN_TYPE_NONE,
- SIGNIN_TYPE_CLIENT_LOGIN,
SIGNIN_TYPE_WITH_CREDENTIALS,
};
std::string SigninTypeToString(SigninType type);
-
friend class FakeSigninManager;
FRIEND_TEST_ALL_PREFIXES(SigninManagerTest, ClearTransientSigninData);
FRIEND_TEST_ALL_PREFIXES(SigninManagerTest, ProvideSecondFactorSuccess);
« no previous file with comments | « chrome/browser/signin/fake_signin_manager.cc ('k') | chrome/browser/signin/signin_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698