Port custom element layout tests to Dart

Port custom element layout tests to Dart

These are adapted from Dominic's tests here:
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/custom/

R=blois@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26319

[vsm, 2013-08-16 23:00:06]

Organizational / refactoring comments welcome as well.  I'm tempted to put these
in their own directory.

[vsm, 2013-08-16 23:00:54]

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/html.status...
tests/html/html.status:21: # Issue 9326 failures
I still need to update the status for dart2js.

[Siggi Cherem (dart-lang), 2013-08-16 23:02:19]

looks awesome (just a cursory look on my part though)

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
File tests/html/custom_element_attribute_changed_test.dart (right):

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
tests/html/custom_element_attribute_changed_test.dart:10: class CustomA extends
HtmlElement {
so so so awesome!

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
File tests/html/custom_element_document_register_test.dart (right):

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
tests/html/custom_element_document_register_test.dart:245: var barFooCreated =
document.$dom_createElement(CustomBar2.tag, CustomFoo.tag);
long line

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
tests/html/custom_element_document_register_test.dart:276:
document.$dom_createElementNS('http://example.com/2013/no-such-namespace',
here too?

[blois, 2013-08-16 23:37:48]

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
File tests/html/custom_element_attribute_changed_test.dart (right):

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
tests/html/custom_element_attribute_changed_test.dart:6: import
'../../pkg/unittest/lib/unittest.dart';
we should use package: imports for new tests.

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
File tests/html/custom_element_created_test.dart (right):

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
tests/html/custom_element_created_test.dart:57:
useHtmlIndividualConfiguration();
I wouldn't use the individual config unless we expect to enable/disable specific
groups within this- it's a bit slower.

[dominicc (has gone to gerrit), 2013-08-17 00:45:56]

This looks very neat.

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
File tests/html/custom_element_created_test.dart (right):

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
tests/html/custom_element_created_test.dart:44:
expect(query('x-c:not(:unresolved)'), this);
FYI this test changed in r156141. Upgrade happens in post-order instead of
reverse order now.

[vsm, 2013-08-19 17:00:10]

PTAL.  I moved these tests in the separate sub-directory (html/custom).

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
File tests/html/custom_element_attribute_changed_test.dart (right):

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
tests/html/custom_element_attribute_changed_test.dart:6: import
'../../pkg/unittest/lib/unittest.dart';
On 2013/08/16 23:37:48, blois wrote:
> we should use package: imports for new tests.

Done.

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
File tests/html/custom_element_created_test.dart (right):

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
tests/html/custom_element_created_test.dart:44:
expect(query('x-c:not(:unresolved)'), this);
Thanks for the catch!

On 2013/08/17 00:45:56, dominicc wrote:
> FYI this test changed in r156141. Upgrade happens in post-order instead of
> reverse order now.

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
tests/html/custom_element_created_test.dart:57:
useHtmlIndividualConfiguration();
I've refactored all the tests to:
(a) go under html/custom/
(b) use separate files instead of groups.  this better matches the JS tests
anyway.

On 2013/08/16 23:37:48, blois wrote:
> I wouldn't use the individual config unless we expect to enable/disable
specific
> groups within this- it's a bit slower.

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
File tests/html/custom_element_document_register_test.dart (right):

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
tests/html/custom_element_document_register_test.dart:245: var barFooCreated =
document.$dom_createElement(CustomBar2.tag, CustomFoo.tag);
On 2013/08/16 23:02:19, Siggi Cherem (dart-lang) wrote:
> long line

Done.

https://chromiumcodereview.appspot.com/23232005/diff/1/tests/html/custom_elem...
tests/html/custom_element_document_register_test.dart:276:
document.$dom_createElementNS('http://example.com/2013/no-such-namespace',
On 2013/08/16 23:02:19, Siggi Cherem (dart-lang) wrote:
> here too?

Done.

[blois, 2013-08-19 17:25:21]

lgtm

https://chromiumcodereview.appspot.com/23232005/diff/11001/tests/html/custom/...
File tests/html/custom/created_callback_test.dart (right):

https://chromiumcodereview.appspot.com/23232005/diff/11001/tests/html/custom/...
tests/html/custom/created_callback_test.dart:75: -c id="t"></x-c>
Is this correct here?

[vsm, 2013-08-19 17:50:49]

Committed patchset #4 manually as r26319 (presubmit successful).