Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 23189006: Ingnore unsupported arguments in TraceEventAnalyzer. (Closed)

Created:
7 years, 4 months ago by ernstm
Modified:
7 years, 4 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Ingnore unsupported arguments in TraceEventAnalyzer. Trace events now carry Dictionary arguments (https://codereview.chromium.org/23088002/), which cause TraceEventAnalyzer to fail hard. Changing the behavior to issue a warning instead and ignore the unsupported arguments. R=phajdan.jr@chromium.org BUG=266101, 264308 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/test/trace_event_analyzer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ernstm
7 years, 4 months ago (2013-08-14 21:46:59 UTC) #1
Paweł Hajdan Jr.
Redirecting to nduca, I can do the final stamp.
7 years, 4 months ago (2013-08-14 22:15:32 UTC) #2
nduca
lgtm
7 years, 4 months ago (2013-08-14 22:32:15 UTC) #3
Paweł Hajdan Jr.
LGTM
7 years, 4 months ago (2013-08-14 22:49:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/23189006/1
7 years, 4 months ago (2013-08-14 22:51:06 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-15 07:20:31 UTC) #6
Message was sent while issue was closed.
Change committed as 217761

Powered by Google App Engine
This is Rietveld 408576698