Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: base/test/trace_event_analyzer.cc

Issue 23189006: Ingnore unsupported arguments in TraceEventAnalyzer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/trace_event_analyzer.cc
diff --git a/base/test/trace_event_analyzer.cc b/base/test/trace_event_analyzer.cc
index 94d49a4636283d748b13b015214e7e2789b55ca1..adefe0a3d623aa18d52e8b0e4297b03b3058f3ee 100644
--- a/base/test/trace_event_analyzer.cc
+++ b/base/test/trace_event_analyzer.cc
@@ -94,9 +94,9 @@ bool TraceEvent::SetFromJSON(const base::Value* event_value) {
else if (it.value().GetAsDouble(&double_num))
arg_numbers[it.key()] = double_num;
else {
- LOG(ERROR) << "Value type of argument is not supported: " <<
+ LOG(WARNING) << "Value type of argument is not supported: " <<
static_cast<int>(it.value().GetType());
- return false; // Invalid trace event JSON format.
+ continue; // Skip non-supported arguments.
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698