Issue 23164007: [Telemetry] Don't mistake an android content_shell directory for a desktop binary.

Issue 23164007: [Telemetry] Don't mistake an android content_shell directory for a desktop binary. (Closed)

Created:
7 years, 4 months ago by tonyg

Modified:
7 years, 4 months ago

Reviewers:
dtu, eseidel

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, eseidel

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Don't mistake an android content_shell directory for a desktop binary. BUG=273230 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217751

Patch Set 1 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -5 lines)			Patch
	M	tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py	View		4 chunks	+8 lines, -5 lines	1 comment	Download
	M	tools/telemetry/telemetry/unittest/system_stub.py	View		3 chunks	+8 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/23164007/diff/1/tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py File tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py (right): https://codereview.chromium.org/23164007/diff/1/tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py#newcode154 tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py:154: return os.path.isfile(path) and os.access(path, os.X_OK) webkitpy got a ...

7 years, 4 months ago (2013-08-14 22:08:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/23164007/1

7 years, 4 months ago (2013-08-14 22:25:31 UTC) #4

Message was sent while issue was closed.

Change committed as 217751

Expand Messages | Collapse Messages