Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: tools/telemetry/telemetry/unittest/system_stub.py

Issue 23164007: [Telemetry] Don't mistake an android content_shell directory for a desktop binary. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/unittest/system_stub.py
diff --git a/tools/telemetry/telemetry/unittest/system_stub.py b/tools/telemetry/telemetry/unittest/system_stub.py
index 42078444e744b0e788d3fa522af26b6cd2a405ef..b647f5fb5930d35298b01610f1af91cb2a437043 100644
--- a/tools/telemetry/telemetry/unittest/system_stub.py
+++ b/tools/telemetry/telemetry/unittest/system_stub.py
@@ -88,6 +88,9 @@ class OsModuleStub(object):
def exists(self, path):
return path in self.files
+ def isfile(self, path):
+ return path in self.files
+
def join(self, *paths):
def IsAbsolutePath(path):
if self.sys.platform.startswith('win'):
@@ -115,6 +118,8 @@ class OsModuleStub(object):
def dirname(self, filename): # pylint: disable=R0201
return os.path.dirname(filename)
+ X_OK = os.X_OK
eseidel 2013/08/14 22:08:56 Ah, I see you do have some sort of mock for os.
+
def __init__(self, sys_module=real_sys):
self.path = OsModuleStub.OsPathModuleStub(sys_module)
self.display = ':0'
@@ -123,6 +128,9 @@ class OsModuleStub(object):
self.program_files_x86 = None
self.devnull = os.devnull
+ def access(self, path, _):
+ return path in self.path.files
+
def getenv(self, name):
if name == 'DISPLAY':
return self.display

Powered by Google App Engine
This is Rietveld 408576698