Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 23163004: Improve 'document.cookie' access check exception messages. (Closed)

Created:
7 years, 4 months ago by Mike West
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Improve 'document.cookie' access check exception messages. BUG=152212 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156307

Patch Set 1 #

Patch Set 2 : test. #

Patch Set 3 : throwSecurityErrro #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -2 lines) Patch
A LayoutTests/fast/cookies/cookies-disabled-in-data-url.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/fast/cookies/cookies-disabled-in-data-url-expected.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/fast/frames/resources/sandboxed-iframe-storage-allowed.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/frames/resources/sandboxed-iframe-storage-disallowed.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/frames/sandboxed-iframe-storage-expected.txt View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike West
Exceptions! For 'document.cookies'! Hooray! -mike
7 years, 4 months ago (2013-08-19 07:37:55 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-19 08:46:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/23163004/7001
7 years, 4 months ago (2013-08-19 08:58:34 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/frames/resources/sandboxed-iframe-storage-disallowed.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 4 months ago (2013-08-19 09:45:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/23163004/20001
7 years, 4 months ago (2013-08-19 11:52:51 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-19 13:20:39 UTC) #6
Message was sent while issue was closed.
Change committed as 156307

Powered by Google App Engine
This is Rietveld 408576698