Emergency fix for Mac: crash with EXC_ARITHMETIC in submit_bulk_transfer

Emergency fix for Mac: crash with EXC_ARITHMETIC in submit_bulk_transfer.

usb_interface_t::GetPipeProperties may fail when the device is unplugged if DeviceVersion is not greater than 320. This case maxPacketSize will be zero on official build and the integer division will may throw a EXC_ARITHMETIC signal.

BUG=278058
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219327

[Bei Zhang, 2013-08-23 09:16:14]

Hi Mustafa,

Please review.

Thanks,
Bei

[meacer, 2013-08-23 16:57:27]

https://codereview.chromium.org/23137025/diff/1/third_party/libusb/src/libusb...
File third_party/libusb/src/libusb/os/darwin_usb.c (right):

https://codereview.chromium.org/23137025/diff/1/third_party/libusb/src/libusb...
third_party/libusb/src/libusb/os/darwin_usb.c:1451: ret =
(*(cInterface->interface))->GetPipeProperties (cInterface->interface, pipeRef,
&direction, &number,
GetPipeProperties are called twice more in this file without error checking.
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libusb...)

Do you think we need to add checks there as well?

[Bei Zhang, 2013-08-23 17:07:27]

https://codereview.chromium.org/23137025/diff/1/third_party/libusb/src/libusb...
File third_party/libusb/src/libusb/os/darwin_usb.c (right):

https://codereview.chromium.org/23137025/diff/1/third_party/libusb/src/libusb...
third_party/libusb/src/libusb/os/darwin_usb.c:1451: ret =
(*(cInterface->interface))->GetPipeProperties (cInterface->interface, pipeRef,
&direction, &number,
Other calls in this file doesn't seem to cause any problem if left as is.
Though, one of them is redundant. I will say leave them as is for now.

On 2013/08/23 16:57:27, Mustafa Emre Acer wrote:
> GetPipeProperties are called twice more in this file without error checking.
>
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libusb...)
> 
> Do you think we need to add checks there as well?

[meacer, 2013-08-23 17:10:04]

LGTM

https://codereview.chromium.org/23137025/diff/1/third_party/libusb/src/libusb...
File third_party/libusb/src/libusb/os/darwin_usb.c (right):

https://codereview.chromium.org/23137025/diff/1/third_party/libusb/src/libusb...
third_party/libusb/src/libusb/os/darwin_usb.c:1451: ret =
(*(cInterface->interface))->GetPipeProperties (cInterface->interface, pipeRef,
&direction, &number,
On 2013/08/23 17:07:28, Bei Zhang wrote:
> Other calls in this file doesn't seem to cause any problem if left as is.
> Though, one of them is redundant. I will say leave them as is for now.
> 
> On 2013/08/23 16:57:27, Mustafa Emre Acer wrote:
> > GetPipeProperties are called twice more in this file without error checking.
> >
>
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libusb...)
> > 
> > Do you think we need to add checks there as well?
> 

Sounds good, thanks Bei.

[commit-bot: I haz the power, 2013-08-23 17:13:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ikarienator@chromium.org/23137025/1

[commit-bot: I haz the power, 2013-08-23 20:42:41]

Change committed as 219327