third_party/libusb/darwin-sigfpe.patch - Issue 23137025: Emergency fix for Mac: crash with EXC_ARITHMETIC in submit_bulk_transfer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libusb/darwin-sigfpe.patch

Issue 23137025: Emergency fix for Mac: crash with EXC_ARITHMETIC in submit_bulk_transfer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 diff --git a/libusb/os/darwin_usb.c b/libusb/os/darwin_usb.c

	2 index b0ee5b2..fe40899 100644

	3 --- a/libusb/os/darwin_usb.c

	4 +++ b/libusb/os/darwin_usb.c

	5 @@ -1449,8 +1449,14 @@ static int submit_bulk_transfer(struct usbi_transfer *itr ansfer) {

	6

	7 cInterface = &priv->interfaces[iface];

	8

	9 - (*(cInterface->interface))->GetPipeProperties (cInterface->interface, pipeRef , &direction, &number,

	10 - &transferType, &maxPacketSize, &interval);

	11 + ret = (*(cInterface->interface))->GetPipeProperties (cInterface->interface, p ipeRef, &direction, &number,

	12 + &transferType, &maxPacke tSize, &interval);

	13 +

	14 + if (ret) {

	15 + usbi_err (TRANSFER_CTX (transfer), "bulk transfer failed (dir = %s): %s (co de = 0x%08x)", IS_XFERIN(transfer) ? "In" : "Out",

	16 + darwin_error_str(ret), ret);

	17 + return darwin_to_libusb (ret);

	18 + }

	19

	20 if (0 != (transfer->length % maxPacketSize)) {

	21 /* do not need a zero packet */

	22

OLD	NEW

« no previous file with comments | « third_party/libusb/README.chromium ('k') | third_party/libusb/src/libusb/os/darwin_usb.c » ('j') | third_party/libusb/src/libusb/os/darwin_usb.c » ('J')