Issue 23135019: Make SyncableFileSystemOperation not inherit from FileSystemOperationImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23135019: Make SyncableFileSystemOperation not inherit from FileSystemOperationImpl (Closed)

Created:
7 years, 3 months ago by kinuko

Modified:
7 years, 3 months ago

Reviewers:
nhiroki, tzik

CC:
chromium-reviews, nhiroki+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make SyncableFileSystemOperation not inherit from FileSystemOperationImpl This is necessary not to expose FileSystemOperationImpl to chrome/ and to reduce the dependency chrome -> webkit dependencies. - Move FileSystemOperationImpl-only methods to FileSystemOperation interface (Now all FSO implementations implement them) - Make SyncableFileSystemOperation inherit from FileSystemOperation (instead of Impl) - Other minor fixups BUG=266215 TEST=existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219734

Patch Set 1 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+199 lines, -152 lines)			Patch
M	chrome/browser/sync_file_system/local/syncable_file_system_operation.h	View	4 chunks	+20 lines, -5 lines	0 comments	Download
M	chrome/browser/sync_file_system/local/syncable_file_system_operation.cc	View	2 chunks	+41 lines, -5 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation.h	View	3 chunks	+93 lines, -5 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_impl.h	View	1 chunk	+15 lines, -74 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_impl.cc	View	2 chunks	+12 lines, -16 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_runner.h	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_runner.cc	View	7 chunks	+18 lines, -32 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23135019/19001

7 years, 3 months ago (2013-08-27 03:29:20 UTC) #4

Message was sent while issue was closed.

Change committed as 219734

Expand Messages | Collapse Messages