tests/lib/typed_data/float32x4_cross_test.dart - Issue 23134002: Replace shuffle getters with shuffle method and masks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/lib/typed_data/float32x4_cross_test.dart

Issue 23134002: Replace shuffle getters with shuffle method and masks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/typed_data/dart2js/typed_data_dart2js.dart ('K') | « sdk/lib/typed_data/typed_data.dart ('k') | tests/lib/typed_data/float32x4_shuffle_test.dart » ('j') | tests/lib/typed_data/float32x4_shuffle_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/lib/typed_data/float32x4_cross_test.dart

diff --git a/tests/lib/typed_data/float32x4_cross_test.dart b/tests/lib/typed_data/float32x4_cross_test.dart

index 0816846ce062e9324d8826eae796c949726ba54a..321a4ac24fa7ebbe089d3e5003ea51f7b7ed2d18 100644

--- a/tests/lib/typed_data/float32x4_cross_test.dart

+++ b/tests/lib/typed_data/float32x4_cross_test.dart

@@ -10,11 +10,11 @@ import 'dart:typed_data';

import 'package:expect/expect.dart';

Float32x4 cross(Float32x4 a, Float32x4 b) {

- var t0 = a.yzxw;

- var t1 = b.zxyw;

+ var t0 = a.shuffle(Float32x4.yzxw);

+ var t1 = b.shuffle(Float32x4.zxyw);

var l = t0 * t1;

- t0 = a.zxyw;

- t1 = b.yzxw;

+ t0 = a.shuffle(Float32x4.zxyw);

+ t1 = b.shuffle(Float32x4.yzxw);

var r = t0 * t1;

return l-r;

}