Replace shuffle getters with shuffle method and masks.

Replace shuffle getters with shuffle method and masks.

BUG=
R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26278

[zra, 2013-08-13 23:00:58]

https://codereview.chromium.org/23134002/diff/3001/tests/lib/typed_data/float...
File tests/lib/typed_data/float32x4_shuffle_test.dart (right):

https://codereview.chromium.org/23134002/diff/3001/tests/lib/typed_data/float...
tests/lib/typed_data/float32x4_shuffle_test.dart:1343: for (int i = 0; i < 4000;
i++) {
Was it necessary to increase this for the optimizer to trigger?

[siva, 2013-08-14 18:27:54]

https://chromiumcodereview.appspot.com/23134002/diff/3001/runtime/lib/typed_d...
File runtime/lib/typed_data.dart (right):

https://chromiumcodereview.appspot.com/23134002/diff/3001/runtime/lib/typed_d...
runtime/lib/typed_data.dart:2281: static const int wwww = 0xFF;
Why do these constants have be defined here as well?
They are already defined in sdk/lib/typed_data/typed_data.dart

https://chromiumcodereview.appspot.com/23134002/diff/3001/sdk/lib/typed_data/...
File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right):

https://chromiumcodereview.appspot.com/23134002/diff/3001/sdk/lib/typed_data/...
sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:1189: static const int wwww =
0xFF;
Same question about the constants here being duplicated?

[Cutch, 2013-08-14 21:15:28]

https://chromiumcodereview.appspot.com/23134002/diff/3001/runtime/lib/typed_d...
File runtime/lib/typed_data.dart (right):

https://chromiumcodereview.appspot.com/23134002/diff/3001/runtime/lib/typed_d...
runtime/lib/typed_data.dart:2281: static const int wwww = 0xFF;
On 2013/08/14 18:27:54, siva wrote:
> Why do these constants have be defined here as well?
> They are already defined in sdk/lib/typed_data/typed_data.dart

Removed.

https://chromiumcodereview.appspot.com/23134002/diff/3001/sdk/lib/typed_data/...
File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right):

https://chromiumcodereview.appspot.com/23134002/diff/3001/sdk/lib/typed_data/...
sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:1189: static const int wwww =
0xFF;
On 2013/08/14 18:27:54, siva wrote:
> Same question about the constants here being duplicated?

These need to be here because the sdk's Float32x4 class is not used in dart2js.

https://chromiumcodereview.appspot.com/23134002/diff/3001/tests/lib/typed_dat...
File tests/lib/typed_data/float32x4_shuffle_test.dart (right):

https://chromiumcodereview.appspot.com/23134002/diff/3001/tests/lib/typed_dat...
tests/lib/typed_data/float32x4_shuffle_test.dart:1343: for (int i = 0; i < 4000;
i++) {
No, left over from testing. I will remove this.

[Cutch, 2013-08-14 21:16:30]

PTAL at P.S.4.

[siva, 2013-08-16 03:46:09]

lgtm

[Cutch, 2013-08-16 16:19:25]

Committed patchset #5 manually as r26278 (presubmit successful).