Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23133006: Merge ContentDistributor into ElementShadow (Closed)

Created:
7 years, 4 months ago by esprehn
Modified:
7 years, 4 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears
Visibility:
Public.

Description

Merge ContentDistributor into ElementShadow ContentDistributor is really part of ElementShadow, many of the methods even make you pass in the distributor or the host leading to really weird things like shadow()->distributor().ensureSelectFeatureSet(shadow()). Instead we just merge them together and the code becomes much more clear. I also moved ContentDistribution and ScopeContentDistribution to their own files since they don't need to be in the same file as the distribution process. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156262

Patch Set 1 #

Patch Set 2 : Don't find git copies #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -599 lines) Patch
M Source/core/core.gypi View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/ContainerNodeAlgorithms.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventPathWalker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ComposedShadowTreeWalker.cpp View 1 chunk +0 lines, -1 line 0 comments Download
A Source/core/dom/shadow/ContentDistribution.h View 1 1 chunk +69 lines, -0 lines 0 comments Download
A Source/core/dom/shadow/ContentDistribution.cpp View 1 1 chunk +70 lines, -0 lines 0 comments Download
D Source/core/dom/shadow/ContentDistributor.h View 1 chunk +0 lines, -135 lines 0 comments Download
D Source/core/dom/shadow/ContentDistributor.cpp View 1 chunk +0 lines, -339 lines 0 comments Download
M Source/core/dom/shadow/ElementShadow.h View 4 chunks +35 lines, -41 lines 1 comment Download
M Source/core/dom/shadow/ElementShadow.cpp View 2 chunks +211 lines, -0 lines 0 comments Download
M Source/core/dom/shadow/InsertionPoint.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/shadow/InsertionPoint.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
A + Source/core/dom/shadow/ScopeContentDistribution.h View 3 chunks +4 lines, -66 lines 0 comments Download
A Source/core/dom/shadow/ScopeContentDistribution.cpp View 1 chunk +104 lines, -0 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/HTMLContentElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
esprehn
7 years, 4 months ago (2013-08-16 05:03:02 UTC) #1
gmorrita
lgtm. https://codereview.chromium.org/23133006/diff/3001/Source/core/dom/shadow/ElementShadow.h File Source/core/dom/shadow/ElementShadow.h (right): https://codereview.chromium.org/23133006/diff/3001/Source/core/dom/shadow/ElementShadow.h#newcode95 Source/core/dom/shadow/ElementShadow.h:95: bool m_needsSelectFeatureSet; It's time to switch bitfields!
7 years, 4 months ago (2013-08-16 05:26:01 UTC) #2
gmorrita
On 2013/08/16 05:26:01, morrita wrote: > lgtm. > > https://codereview.chromium.org/23133006/diff/3001/Source/core/dom/shadow/ElementShadow.h > File Source/core/dom/shadow/ElementShadow.h (right): > ...
7 years, 4 months ago (2013-08-16 05:26:25 UTC) #3
esprehn
On 2013/08/16 05:26:01, morrita wrote: > lgtm. > > https://codereview.chromium.org/23133006/diff/3001/Source/core/dom/shadow/ElementShadow.h > File Source/core/dom/shadow/ElementShadow.h (right): > ...
7 years, 4 months ago (2013-08-17 01:03:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/23133006/3001
7 years, 4 months ago (2013-08-17 01:04:08 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=2457
7 years, 4 months ago (2013-08-17 04:36:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/23133006/3001
7 years, 4 months ago (2013-08-17 05:16:49 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-17 06:01:27 UTC) #8
Message was sent while issue was closed. 
Change committed as 156262

Powered by Google App Engine
This is Rietveld 408576698