Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 23133002: Disk cache: Remove not needed memory comparison from unit test. (Closed)

Created:
7 years, 4 months ago by rvargas (doing something else)
Modified:
7 years, 4 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Visibility:
Public.

Description

Disk cache: Remove not needed memory comparison from unit test. The second part of this test only cares about the number of bytes read, so the attempt to verify the contents was not really needed. BUG=271530 TEST=net_unittests R=wtc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M net/disk_cache/entry_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rvargas (doing something else)
7 years, 4 months ago (2013-08-13 21:53:43 UTC) #1
wtc
LGTM. Thanks!
7 years, 4 months ago (2013-08-13 22:53:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/23133002/1
7 years, 4 months ago (2013-08-13 22:57:46 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-14 05:58:07 UTC) #4
Message was sent while issue was closed.
Change committed as 217492

Powered by Google App Engine
This is Rietveld 408576698