net/disk_cache/entry_unittest.cc - Issue 23133002: Disk cache: Remove not needed memory comparison from unit test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/entry_unittest.cc

Issue 23133002: Disk cache: Remove not needed memory comparison from unit test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/entry_unittest.cc

diff --git a/net/disk_cache/entry_unittest.cc b/net/disk_cache/entry_unittest.cc

index 857e07f1b7b1dcf08f4317eec0f175f07f4af72b..7addc85e5a03b851fd412827823a1f4ee87f4d7a 100644

--- a/net/disk_cache/entry_unittest.cc

+++ b/net/disk_cache/entry_unittest.cc

@@ -392,7 +392,6 @@ void DiskCacheEntryTest::ExternalSyncIOBackground(disk_cache::Entry* entry) {

EXPECT_EQ(

25000,

entry->ReadData(1, 0, buffer2.get(), kSize2, net::CompletionCallback()));

- EXPECT_EQ(0, memcmp(buffer2->data(), buffer2->data(), 10000));

EXPECT_EQ(5000,

entry->ReadData(

1, 30000, buffer2.get(), kSize2, net::CompletionCallback()));

« no previous file with comments | « no previous file | no next file » | no next file with comments »