Bring windows with new tabs to foreground

Bring windows with just opened tabs to foreground.

BUG=164227
TEST=On various platforms, bring another window on top of a Chrome one, then click a button on a notification. A tab will be opened, and the whole window where the tab is should be brought to foreground.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217680

[rgustafson, 2013-08-14 00:33:20]

What platforms is this broken on? Useful info to include. I wanted to repro the
issue and verify that there wasn't any wonkyness with windows too. Was there
never a bug for this?

[vadimt, 2013-08-14 00:45:06]

The original issue happened on Mac.
However, I've noticed that on Windows the added call invokes SetForegroundWindow
Windows API call, while simply adding a tab doesn't do this.
Additionally, tabs.create documentation doesn't promise bringing the window to
foreground.
Combining all of this, it appears safer and more correct to add this
windows.update call.

[skare_, 2013-08-14 00:53:18]

lgtm

[rgustafson, 2013-08-14 01:02:02]

https://codereview.chromium.org/23128005/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/23128005/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:597:
chrome.windows.create({url: url});
My concern is whether the same will happen with this guy as with the tabs. Set
focused to true here also for completeness? (don't need the extra update call,
just do it in create)

[vadimt, 2013-08-14 01:35:03]

https://codereview.chromium.org/23128005/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/23128005/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:597:
chrome.windows.create({url: url});
On 2013/08/14 01:02:03, rgustafson wrote:
> My concern is whether the same will happen with this guy as with the tabs. Set
> focused to true here also for completeness? (don't need the extra update call,
> just do it in create)

Done.

[rgustafson, 2013-08-14 01:53:19]

lgtm

[vadimt, 2013-08-14 01:55:32]

arv@, please provide OWNER's approval

[arv (Not doing code reviews), 2013-08-14 15:40:58]

LGTM

[commit-bot: I haz the power, 2013-08-14 16:50:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vadimt@chromium.org/23128005/9001

[commit-bot: I haz the power, 2013-08-14 17:49:09]

Retried try job too often on linux_aura for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-08-14 20:03:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vadimt@chromium.org/23128005/44001

[commit-bot: I haz the power, 2013-08-14 23:00:02]

Change committed as 217680