chrome/browser/resources/google_now/background.js - Issue 23128005: Bring windows with new tabs to foreground

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/google_now/background.js

Issue 23128005: Bring windows with new tabs to foreground (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing unit tests. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/google_now/background.js

diff --git a/chrome/browser/resources/google_now/background.js b/chrome/browser/resources/google_now/background.js

index fdeee8ca3b63bc48b0330017360cd6cc5836da9c..c6e38f24bb517ba3b2bf169b35fc144d176e159a 100644

--- a/chrome/browser/resources/google_now/background.js

+++ b/chrome/browser/resources/google_now/background.js

@@ -604,8 +604,10 @@ function onNotificationClicked(notificationId, selector) {

return;

instrumented.tabs.create({url: url}, function(tab) {

- if (!tab)

- chrome.windows.create({url: url});

+ if (tab)

+ chrome.windows.update(tab.windowId, {focused: true});

+ else

+ chrome.windows.create({url: url, focused: true});

});

}

« no previous file with comments | « no previous file | chrome/browser/resources/google_now/background_unittest.gtestjs » ('j') | no next file with comments »