App install alert button fixes

App install alert button fixes

* Limits the maximum size of the button, truncating text if it can't fit
  (yay for testing with languages that I didn't have translations for
  initially).

* Stops an NPE that can trigger if the user uses the banner to install an
  app, uninstalls the app in the background, then returns to Chrome to
  open the app from the banner itself.

BUG=359208, 359199
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262926

[newt (away), 2014-04-09 19:01:05]

lgtm

https://chromiumcodereview.appspot.com/231273003/diff/1/chrome/android/java/r...
File chrome/android/java/res/layout/app_banner_view.xml (right):

https://chromiumcodereview.appspot.com/231273003/diff/1/chrome/android/java/r...
chrome/android/java/res/layout/app_banner_view.xml:40: android:ellipsize="end"
Once the user clicks on the button, you could consider changing ellipsize="end"
to marqueeing once. At that point, we know the user is interested in the app
banner. I agree that initially we should avoid distracting the user with a
marquee.

https://chromiumcodereview.appspot.com/231273003/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
(right):

https://chromiumcodereview.appspot.com/231273003/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java:639:
// Restrict the button size to prevent overrunning the all-important Google Play
logo.
you forgot capitalization: "All-Important"

[gone, 2014-04-09 20:28:44]

https://chromiumcodereview.appspot.com/231273003/diff/1/chrome/android/java/r...
File chrome/android/java/res/layout/app_banner_view.xml (right):

https://chromiumcodereview.appspot.com/231273003/diff/1/chrome/android/java/r...
chrome/android/java/res/layout/app_banner_view.xml:40: android:ellipsize="end"
On 2014/04/09 19:01:05, newt wrote:
> Once the user clicks on the button, you could consider changing
ellipsize="end"
> to marqueeing once. At that point, we know the user is interested in the app
> banner. I agree that initially we should avoid distracting the user with a
> marquee.

Marqueeing just looks really distracting.

https://chromiumcodereview.appspot.com/231273003/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
(right):

https://chromiumcodereview.appspot.com/231273003/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java:639:
// Restrict the button size to prevent overrunning the all-important Google Play
logo.
On 2014/04/09 19:01:05, newt wrote:
> you forgot capitalization: "All-Important"

Done, sort of.

[David Trainor- moved to gerrit, 2014-04-10 00:03:09]

lgtm

[gone, 2014-04-10 00:03:44]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2014-04-10 00:04:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/231273003/20001

[commit-bot: I haz the power, 2014-04-10 05:15:58]

Change committed as 262926