Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Side by Side Diff: chrome/android/java/res/layout/app_banner_view.xml

Issue 231273003: App install alert button fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing comment. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. 4 found in the LICENSE file.
5 --> 5 -->
6 6
7 <org.chromium.chrome.browser.banners.AppBannerView 7 <org.chromium.chrome.browser.banners.AppBannerView
8 xmlns:android="http://schemas.android.com/apk/res/android" 8 xmlns:android="http://schemas.android.com/apk/res/android"
9 android:id="@+id/app_banner_view" 9 android:id="@+id/app_banner_view"
10 android:background="@drawable/card_background_default" 10 android:background="@drawable/card_background_default"
(...skipping 17 matching lines...) Expand all
28 android:lines="1" 28 android:lines="1"
29 android:ellipsize="end" 29 android:ellipsize="end"
30 android:layout_width="wrap_content" 30 android:layout_width="wrap_content"
31 android:layout_height="wrap_content" 31 android:layout_height="wrap_content"
32 android:layout_marginTop="@dimen/app_banner_title_margin_top" 32 android:layout_marginTop="@dimen/app_banner_title_margin_top"
33 android:layout_marginBottom="@dimen/app_banner_title_margin_bottom" /> 33 android:layout_marginBottom="@dimen/app_banner_title_margin_bottom" />
34 34
35 <!-- Button that triggers installation and opening of the app. --> 35 <!-- Button that triggers installation and opening of the app. -->
36 <Button 36 <Button
37 android:id="@+id/app_install_button" 37 android:id="@+id/app_install_button"
38 android:background="@drawable/app_banner_button_install" 38 style="@style/AppBannerButton"
39 android:textColor="@color/app_banner_install_button_fg"
40 android:ellipsize="end"
41 android:singleLine="true"
39 android:minHeight="@dimen/app_banner_button_height" 42 android:minHeight="@dimen/app_banner_button_height"
40 android:lines="1"
41 android:textAppearance="@style/AppBannerButton"
42 android:paddingStart="@dimen/app_banner_button_padding_sides" 43 android:paddingStart="@dimen/app_banner_button_padding_sides"
43 android:paddingEnd="@dimen/app_banner_button_padding_sides" 44 android:paddingEnd="@dimen/app_banner_button_padding_sides"
44 android:paddingTop="@dimen/app_banner_button_padding_above_below" 45 android:paddingTop="@dimen/app_banner_button_padding_above_below"
45 android:paddingBottom="@dimen/app_banner_button_padding_above_below" 46 android:paddingBottom="@dimen/app_banner_button_padding_above_below"
46 android:layout_width="wrap_content" 47 android:layout_width="wrap_content"
47 android:layout_height="wrap_content" 48 android:layout_height="wrap_content"
48 android:layout_marginTop="@dimen/app_banner_button_margin_top" 49 android:layout_marginTop="@dimen/app_banner_button_margin_top" />
49 android:layout_marginStart="@dimen/app_banner_button_margin_start" / >
50 50
51 <!-- Logo for the store. --> 51 <!-- Logo for the store. -->
52 <ImageView 52 <ImageView
53 android:id="@+id/store_logo" 53 android:id="@+id/store_logo"
54 android:src="@drawable/google_play_logo" 54 android:src="@drawable/google_play_logo"
55 android:adjustViewBounds="true" 55 android:adjustViewBounds="true"
56 android:layout_width="wrap_content" 56 android:layout_width="wrap_content"
57 android:layout_height="@dimen/app_banner_logo_height" 57 android:layout_height="@dimen/app_banner_logo_height"
58 android:layout_marginTop="@dimen/app_banner_logo_margin_top" 58 android:layout_marginTop="@dimen/app_banner_logo_margin_top"
59 android:layout_marginBottom="@dimen/app_banner_logo_margin_bottom" / > 59 android:layout_marginBottom="@dimen/app_banner_logo_margin_bottom"
60 android:layout_marginEnd="@dimen/app_banner_logo_margin_end"/>
60 61
61 <!-- View showing how well the app is rated. --> 62 <!-- View showing how well the app is rated. -->
62 <org.chromium.chrome.browser.banners.RatingView 63 <org.chromium.chrome.browser.banners.RatingView
63 android:id="@+id/app_rating" 64 android:id="@+id/app_rating"
64 android:adjustViewBounds="true" 65 android:adjustViewBounds="true"
65 android:layout_width="wrap_content" 66 android:layout_width="wrap_content"
66 android:layout_height="@dimen/app_banner_star_height" /> 67 android:layout_height="@dimen/app_banner_star_height" />
67 68
68 <!-- Button that closes the banner. --> 69 <!-- Button that closes the banner. -->
69 <ImageButton 70 <ImageButton
70 android:id="@+id/close_button" 71 android:id="@+id/close_button"
71 android:contentDescription="@string/infobar_close" 72 android:contentDescription="@string/infobar_close"
72 android:adjustViewBounds="true" 73 android:adjustViewBounds="true"
73 android:src="@drawable/dismiss" 74 android:src="@drawable/dismiss"
74 android:background="@drawable/app_banner_button_close" 75 android:background="@drawable/app_banner_button_close"
75 android:padding="@dimen/app_banner_close_button_padding" 76 android:padding="@dimen/app_banner_close_button_padding"
76 android:layout_width="wrap_content" 77 android:layout_width="wrap_content"
77 android:layout_height="wrap_content"/> 78 android:layout_height="wrap_content"/>
78 79
79 <!-- View covering the entire banner. Used to indicate the banner is highli ghted. --> 80 <!-- View covering the entire banner. Used to indicate the banner is highli ghted. -->
80 <View 81 <View
81 android:id="@+id/banner_highlight" 82 android:id="@+id/banner_highlight"
82 android:background="@color/app_banner_card_highlight" 83 android:background="@color/app_banner_card_highlight"
83 android:visibility="gone" 84 android:visibility="gone"
84 android:layout_width="match_parent" 85 android:layout_width="match_parent"
85 android:layout_height="match_parent" /> 86 android:layout_height="match_parent" />
86 </org.chromium.chrome.browser.banners.AppBannerView> 87 </org.chromium.chrome.browser.banners.AppBannerView>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698