Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 23112014: Add WebRuntimeFeatures::enableInputModeAttribute (Closed)

Created:
7 years, 4 months ago by yoichio
Modified:
7 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Add WebRuntimeFeatures::enableInputModeAttribute Chromium will use this function to enable inputmode attribute of <input> or <text> Element. BUG=244688 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yoichio
Please take a look.
7 years, 4 months ago (2013-08-22 04:43:22 UTC) #1
tkent
> Chrome will use this function to enable inputmode attribute of <input> or <text> Element ...
7 years, 4 months ago (2013-08-22 04:49:02 UTC) #2
yoichio
On 2013/08/22 04:49:02, tkent wrote: > > Chrome will use this function to enable inputmode ...
7 years, 4 months ago (2013-08-22 05:18:16 UTC) #3
yoichio
On 2013/08/22 05:18:16, yoichio wrote: > On 2013/08/22 04:49:02, tkent wrote: > > > Chrome ...
7 years, 4 months ago (2013-08-22 05:18:42 UTC) #4
tkent
lgtm It makes sense.
7 years, 4 months ago (2013-08-22 05:22:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/23112014/1
7 years, 4 months ago (2013-08-22 05:22:55 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-22 06:43:21 UTC) #7
Message was sent while issue was closed.
Change committed as 156548

Powered by Google App Engine
This is Rietveld 408576698