Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 23103007: Avoid reparsing an XSLT stylesheet after the first failure. (Closed)

Created:
7 years, 4 months ago by f(malita)
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Avoid reparsing an XSLT stylesheet after the first failure. Certain libxslt versions appear to leave the doc in an invalid state when parsing fails. We should cache this result and avoid re-parsing. (The test cannot be converted to text-only due to its invalid stylesheet). R=inferno@chromium.org,abarth@chromium.org,pdr@chromium.org BUG=271939 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/invalid-xslt-crash.svg View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/xml/XSLStyleSheet.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/xml/XSLStyleSheetLibxslt.cpp View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
f(malita)
7 years, 4 months ago (2013-08-16 18:26:50 UTC) #1
inferno
I am not a good reviewer for this code. I would say Adam or Eric.
7 years, 4 months ago (2013-08-16 19:26:15 UTC) #2
f(malita)
On 2013/08/16 19:26:15, inferno wrote: > I am not a good reviewer for this code. ...
7 years, 4 months ago (2013-08-16 19:41:46 UTC) #3
eseidel
This looks OK. This whole subsystem is a disaster. I'm going to need to re-write ...
7 years, 4 months ago (2013-08-16 20:42:12 UTC) #4
eseidel
This looks OK. This whole subsystem is a disaster. I'm going to need to re-write ...
7 years, 4 months ago (2013-08-16 20:42:13 UTC) #5
eseidel
lgtm
7 years, 4 months ago (2013-08-16 20:42:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/23103007/1
7 years, 4 months ago (2013-08-16 20:42:34 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 22:40:30 UTC) #8
Message was sent while issue was closed.
Change committed as 156248

Powered by Google App Engine
This is Rietveld 408576698